From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 64FF97803E8 for ; Thu, 14 Mar 2024 14:46:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qOFyCZTn84KEEpsz+fYZDc5rQic0mxNZg7IlUWaQqDY=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710427574; v=1; b=OX9xKisWf2CS2rDxdr++is+PxYql5ZYtdg0rDpCEBRyYbAdUNiyu42Akv4rnEa2jELDlmzTt JTjOlW/wcvT93HOiPQAOAJAX/1a415nF4xiGtzProYY6XB2RUrEt/T7Mo2p5mFCuS/geznHfTyZ oqjZHKz4qLw19ZTWBhDbqFGzYSk2mIStfaaZVfZQvzM2A4YpA9NLGMODwlQ53qzOCiEvFoTs3t5 xtY+iUviNQEZzOsfFzNiPCvaq6vPoMt9UnjGOq+n/OG/FnV0NegcdhBp1NK/Rtj8bnPxnn58XWf WUPqO8akG2RayCqmIenHzgtw7g8Ab8TjxhzIIP/JuRXPA== X-Received: by 127.0.0.2 with SMTP id Y8xOYY7687511xeUByZO1EWi; Thu, 14 Mar 2024 07:46:14 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.14350.1710427573388212400 for ; Thu, 14 Mar 2024 07:46:13 -0700 X-Received: from [10.137.194.171] (unknown [131.107.159.43]) by linux.microsoft.com (Postfix) with ESMTPSA id D01DC20B74C0; Thu, 14 Mar 2024 07:46:12 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D01DC20B74C0 Message-ID: <6f62f2ed-d167-49da-b25c-1e1dd152d03d@linux.microsoft.com> Date: Thu, 14 Mar 2024 07:46:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdW1BBVENIIHYyIDEvMV0gTWRlTW9kdWxlUGtnOiBSZW1vdmUgQXJtUGtnIERlcGVuZGVuY3k=?= To: gaoliming , devel@edk2.groups.io Cc: 'Leif Lindholm' , 'Ard Biesheuvel' , 'Sami Mujawar' , 'Sean Brogan' , 'Ard Biesheuvel' References: <20240214232009.13637-1-osde@linux.microsoft.com> <034501da761d$f0ce6c00$d26b4400$@byosoft.com.cn> From: "Oliver Smith-Denny" In-Reply-To: <034501da761d$f0ce6c00$d26b4400$@byosoft.com.cn> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 14 Mar 2024 07:46:13 -0700 Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YUq4KzMpYpoLHMJHjpB6FeREx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=OX9xKisW; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for the review! Oliver On 3/14/2024 7:43 AM, gaoliming wrote: > Sorry for the late response. I think this is a good clean up. Reviewed-by= : > Liming Gao >=20 >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: Oliver Smith-Denny >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B42=E6=9C=8815=E6=97=A5= 7:20 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >> =E6=8A=84=E9=80=81: Leif Lindholm ; Ard Biesh= euvel >> ; Sami Mujawar ; >> Liming Gao ; Sean Brogan >> ; Ard Biesheuvel >> =E4=B8=BB=E9=A2=98: [edk2-devel][PATCH v2 1/1] MdeModulePkg: Remove ArmP= kg >> Dependency >> >> With commita21a994f55e53325d3e060c435ca3a87fd7c2c79 >> MdeModulePkg no longer has a hard dependency on ArmMmuLib and >> therefore >> ArmLib. This is the final dependency on ArmPkg, so remove the >> unused libs and drop the allowed dependency on ArmPkg as >> MdeModulePkg should not depend on it as this is a circular >> dependency. >> >> Github PR: https://github.com/tianocore/edk2/pull/5361 >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3651 >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Sami Mujawar >> Cc: Liming Gao >> >> Signed-off-by: Oliver Smith-Denny >> Reviewed-by: Sean Brogan >> Acked-by: Ard Biesheuvel >> --- >> >> Notes: >> v2: >> - Add bugzilla link to commit message >> - Add Sean's RB and Ard's ack >> >> MdeModulePkg/MdeModulePkg.dsc | 2 -- >> MdeModulePkg/MdeModulePkg.ci.yaml | 3 +-- >> 2 files changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/MdeModulePkg/MdeModulePkg.dsc >> b/MdeModulePkg/MdeModulePkg.dsc >> index 6b3052ff4614..c0f1df3bfbca 100644 >> --- a/MdeModulePkg/MdeModulePkg.dsc >> +++ b/MdeModulePkg/MdeModulePkg.dsc >> @@ -179,8 +179,6 @@ [LibraryClasses.common.MM_STANDALONE] >> >> MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMm >> MemLib.inf >> >> [LibraryClasses.ARM, LibraryClasses.AARCH64] >> - ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf >> - ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf >> LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf >> >> # >> diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml >> b/MdeModulePkg/MdeModulePkg.ci.yaml >> index 669f54e33c0d..a3de60a12c9e 100644 >> --- a/MdeModulePkg/MdeModulePkg.ci.yaml >> +++ b/MdeModulePkg/MdeModulePkg.ci.yaml >> @@ -53,8 +53,7 @@ >> "AcceptableDependencies": [ >> "MdePkg/MdePkg.dec", >> "MdeModulePkg/MdeModulePkg.dec", >> - "StandaloneMmPkg/StandaloneMmPkg.dec", >> - "ArmPkg/ArmPkg.dec" # this should be fixed by promoting >> an abstraction >> + "StandaloneMmPkg/StandaloneMmPkg.dec" >> ], >> # For host based unit tests >> "AcceptableDependencies-HOST_APPLICATION":[ >> -- >> 2.40.1 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116758): https://edk2.groups.io/g/devel/message/116758 Mute This Topic: https://groups.io/mt/104927624/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-