From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.14736.1591193236244013650 for ; Wed, 03 Jun 2020 07:07:16 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D543F55D; Wed, 3 Jun 2020 07:07:14 -0700 (PDT) Received: from [192.168.1.69] (unknown [10.37.8.209]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2EF073F52E; Wed, 3 Jun 2020 07:07:13 -0700 (PDT) Subject: Re: [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings To: devel@edk2.groups.io Cc: leif@nuviainc.com, graeme.gregory@linaro.org, tanmay.jagdale@linaro.org, lersek@redhat.com, sami.mujawar@arm.com References: <20200519122351.18405-1-ard.biesheuvel@arm.com> From: "Ard Biesheuvel" Message-ID: <6f6ac3df-60d5-6fda-f102-0def3fcf0b5b@arm.com> Date: Wed, 3 Jun 2020 16:07:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200519122351.18405-1-ard.biesheuvel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/19/20 2:23 PM, Ard Biesheuvel wrote: > Add build time checks for serial terminal settings, so we don't end up > with a non-functional serial console if the PCDs are set incorrectly > > v1 was just the second patch. v2 adds the first patch switching to > STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one > as well. > > Ard Biesheuvel (2): > ArmPkg/PlatformBootManagerLib: use static assertion for console type > ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit > count > > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > Pushed as #655 Thanks all.