From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.73]) by mx.groups.io with SMTP id smtpd.web10.5513.1603140487797420571 for ; Mon, 19 Oct 2020 13:48:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=XsNTSAGj; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.100.73, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cvvuQKvoLBA8MMwoEdBZXnFbSLj0+nw0Jve7hMusY9lPChZvL8zcUlqRFp9dMgI1XBWmpHq4tiXc19ej5XX/btsQ3xTD4SliITverwggin+xHQJWhIRnztgK1bkzRmg2GMMTJGeLyAdxsspLuTi8nsdTRFOGFvBzp/ose8if+XO1+gfrNiZFix8HxS2c0Ze1yAOFtazQQQLPpu+mcrVjieebgawOBYp2rxGHrEqfu8PhjWr7aHXnft1Vkzsb3k06YC48CcTB6HsPj+5ZJzYtfaDX4PnFu+DV+ZzHOrjkWFdGqsxt9lDOV+9Vl+WsJGPR0rW+EtCJvU6qsO1WqfU/Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eCfVq/qbeEbrv4GnSGQGImbrWZAKj86EA2EOW0Gb8mM=; b=QzB2PW2nnZvWy4K7ucFck9uhGjSR+M2IjYjwLLz660Rsv4HMWPtjCy//0hYwx6XtQ0wPjUdxoRp2OSbRy4iJUXZvO+vjim0rmN7xHToxUKu2RvwWU/ks2rLOFmTdmtp6YEttavCnBq89g8IEXu1ZXEWJJtYUiFb8zoIKuj2sEYTq8Ivs4Iygj3xGmf/6xS8Yxr7RtcS1SOQmBZ8Pw8fj2SqVt67bmDBwB5U6EEn+v1FDH12gNirI/U0cbGy4RBPrH/l6SlVP+gAy1RFczUqNmxSwrPmfzgxiFZYe3dllG1Zc1rlAVDrCsrpXRHn37b+YpBjnBlb5esDwq6e6E4cP3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eCfVq/qbeEbrv4GnSGQGImbrWZAKj86EA2EOW0Gb8mM=; b=XsNTSAGjbVCwe48eLwvJQqpmarvPP2CCrcf2GfIqwJtoFEDC2unzdaTW4GjoZJX6CuuMY79IlKT079tEi69Qz9GDzVJEgGsBFRula/APksIQeypxJjnDOChSr/KBvV7CP+tqP9bLc1h0yeP6gjLrAa1KsbXIDo1m1NUnWGPZJ24= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR12MB4679.namprd12.prod.outlook.com (2603:10b6:4:a2::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Mon, 19 Oct 2020 20:48:06 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba%6]) with mapi id 15.20.3477.028; Mon, 19 Oct 2020 20:48:05 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW1BBVENIIHYyIDAxLzExXSBNZGVQa2csIE92bWZQa2c6IENsZWFuIHVwIEdIQ0IgZmllbGQgb2Zmc2V0cyBhbmQgc2F2ZSBhcmVh?= To: Laszlo Ersek , gaoliming , devel@edk2.groups.io Cc: 'Brijesh Singh' , 'Michael D Kinney' , 'Zhiguang Liu' , 'Jordan Justen' , 'Ard Biesheuvel' References: <523f270e4e6f7a62cdbebc541b442bd766e7ab3a.1602864557.git.thomas.lendacky@amd.com> <000d01d6a5b9$03d14ef0$0b73ecd0$@byosoft.com.cn> <93c3b271-ccdb-6242-ce23-957eb73a66c0@amd.com> <4955ba32-2bef-52d2-28be-6d3d179bd131@redhat.com> From: "Lendacky, Thomas" Message-ID: <6f7919bf-2787-7ffe-d23e-6b305478bb12@amd.com> Date: Mon, 19 Oct 2020 15:48:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <4955ba32-2bef-52d2-28be-6d3d179bd131@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR11CA0023.namprd11.prod.outlook.com (2603:10b6:806:d3::28) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.236.30.118] (165.204.77.1) by SA0PR11CA0023.namprd11.prod.outlook.com (2603:10b6:806:d3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25 via Frontend Transport; Mon, 19 Oct 2020 20:48:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 32c12a9f-418b-4797-9a68-08d87470470a X-MS-TrafficTypeDiagnostic: DM5PR12MB4679: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jKd3ZUND1htv9fsRMvWVAaVby+lYuiKiHI499ACK4/dso450kiZNM7RQaSQaYEPIselF7BrKaHOzgKst3wkKIXqXL4Y2Qn0CetOCbObXlN4qELp4/8/cX3ma6M4eY6aGr2vL29QH6FPP6RFSP6PrwtxRsvIZKu7r0kLiAlCTFBmMmSsrSkj6hwjM9EsdT3B5UIiY1MOrzNTg9fbnwfVBcQ8PMkQwEL4WVZnmTN5454Ar3TWMFwSCgIjdQnELGjbDSyKSD9jFCrI3X6Pbl8+RfycYNU8Ll13EQFFjFuojV5kkVgtQwkcgKzrNYtb6lnXIx2IztsyKq/fxIv6GBSw7Zz8luQSgRQKSU5exUOnsTFYDkr0TSFxAK4lhsAEOdv/i X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(6486002)(478600001)(66946007)(5660300002)(4744005)(66476007)(66556008)(83380400001)(224303003)(316002)(86362001)(31686004)(956004)(54906003)(2616005)(110136005)(16576012)(53546011)(186003)(16526019)(36756003)(52116002)(4326008)(2906002)(26005)(31696002)(8936002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: sQYgtjRpd3aOt2AY4uHjOSaIFFQzozCqZJ8OuTtuLs77MhWujxgl7LqK8Tzr/9CxPCX1gOmEzOnEsfbrjVu2kbpDjEBoyc0DqWjYTDN9+SPO5YGo3EeayKFuesOzUIZU34749irJwRSdiJTqlWfu4scI+vkNBs4vUmdgM7RN1GciBuWRh9rK8ySZyWnmg73NT89ID0nk9slGKG4Oalet2SqIf6IsZzJqLfhydUf5i+aLp6S+yEjSHb9QwtzsEtZwqrzuHePDTfq53ad53K6RXXpGoCe4/y6FkUJ6vSeuOC/7vV6QTyKGBW3XF8P1eiXEl3OnkJjhKrEJK5AGfc2EVlf+da+/7C1Ef0tjDFU1CMpNElkv0T0v0JelGFenuxqMHo4sFTrX3qxHMQ9PuCwsm0oVZ04qp2XXtz6hb+SIEugvbggZ6EF4fZ7bPa+dvYeT3puU9M/3pztQ6coKS+nlL6EgtSIkeWmkpq4gFK55z3KnnFupi+YIbbJMXmBtgHQCaaewG7WA6dJsaLzOt0QOHy4Cdxlwu6ImlLnOl8I6Td/WFB6rDVDEGRunMhRwk7n5sNXMDnxUPJeMT0TWQ5GILwyvNnODDUhYi9q12+KfGatB/qf5HszFRcH7wWdQtjTjDSbBGyzzPTDB8bS/+wGVGQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32c12a9f-418b-4797-9a68-08d87470470a X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2020 20:48:05.3160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wK6oTigY+XygETFNKdbrXfpQjm40JUGU+3n3lig9yhIwTcUAmaCz8nFLNZ3JbL+0Lwpnzz7Hs83piJpPAOqV/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB4679 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/19/20 3:17 PM, Laszlo Ersek wrote: > Hi Tom, > > On 10/19/20 14:50, Tom Lendacky wrote: >> On 10/18/20 8:41 PM, gaoliming wrote: > >>>> +typedef enum { >>>> + GhcbCpl = OFFSET_OF (GHCB, SaveArea.Cpl) / sizeof (UINT64), >>> >>> OFFSET_OF (GHCB, SaveArea.Cpl) is 204. But, it can't fully divide 8 >>> (sizeof(UINT64)). Is it correct? Yes, this is correct. Even though the Cpl offset is not on an 8 byte boundary and its size is not a full 8 bytes, any change in that qword range needs to be marked. The calculation will result in a value of 25, which is what the original hardcoded value was. > > > I didn't notice this before, and from your response to Liming, I think > you may have missed Liming pointing it out as well. Yes I did miss it... thanks for spotting that, Laszlo! Thanks, Tom > > Thanks > Laszlo >