public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Cc: star.zeng@intel.com
Subject: Re: [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to DEBUG_BLKIO
Date: Thu, 7 Jun 2018 19:23:08 +0200	[thread overview]
Message-ID: <6f89e8bc-2aef-d7d8-bec4-b491506b2a34@redhat.com> (raw)
In-Reply-To: <20180607091003.8687-1-ard.biesheuvel@linaro.org>

On 06/07/18 11:10, Ard Biesheuvel wrote:
> Lower the priority of the DEBUG print in EmmcReadWrite(), which
> is emitted for each read or write operation to the eMMC device,
> which clutters up the log output of builds created with DEBUG_INFO
> enabled.
> 
> Suggested-by: Pipat Methavanitpong <methavanitpong.pipat@socionext.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
> index e1d0f394a954..f6b230514b71 100644
> --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
> +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
> @@ -901,7 +901,10 @@ EmmcReadWrite (
>      if (EFI_ERROR (Status)) {
>        return Status;
>      }
> -    DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p with %r\n", IsRead ? "Read " : "Write", Partition->PartitionType, Lba, BlockNum, (Token != NULL) ? Token->Event : NULL, Status));
> +    DEBUG ((DEBUG_BLKIO,
> +      "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p with %r\n",
> +      IsRead ? "Read " : "Write", Partition->PartitionType, Lba, BlockNum,
> +      (Token != NULL) ? Token->Event : NULL, Status));
>  
>      Lba   += BlockNum;
>      Buffer = (UINT8*)Buffer + BufferSize;
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


  reply	other threads:[~2018-06-07 17:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07  9:10 [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to DEBUG_BLKIO Ard Biesheuvel
2018-06-07 17:23 ` Laszlo Ersek [this message]
2018-06-08  3:15   ` Zeng, Star
2018-06-11  8:14     ` Ard Biesheuvel
2018-06-11  8:38       ` Wu, Hao A
2018-06-11  8:54         ` Ard Biesheuvel
2018-06-11  9:12           ` Zeng, Star
2018-06-11  9:40             ` Ard Biesheuvel
2018-06-12  2:04             ` Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f89e8bc-2aef-d7d8-bec4-b491506b2a34@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox