From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D02C211093B8 for ; Thu, 7 Jun 2018 10:23:16 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54AEC401EF1B; Thu, 7 Jun 2018 17:23:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-78.rdu2.redhat.com [10.10.121.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC4411117637; Thu, 7 Jun 2018 17:23:14 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: star.zeng@intel.com References: <20180607091003.8687-1-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <6f89e8bc-2aef-d7d8-bec4-b491506b2a34@redhat.com> Date: Thu, 7 Jun 2018 19:23:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180607091003.8687-1-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 07 Jun 2018 17:23:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 07 Jun 2018 17:23:15 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to DEBUG_BLKIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 17:23:16 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/07/18 11:10, Ard Biesheuvel wrote: > Lower the priority of the DEBUG print in EmmcReadWrite(), which > is emitted for each read or write operation to the eMMC device, > which clutters up the log output of builds created with DEBUG_INFO > enabled. > > Suggested-by: Pipat Methavanitpong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > index e1d0f394a954..f6b230514b71 100644 > --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > @@ -901,7 +901,10 @@ EmmcReadWrite ( > if (EFI_ERROR (Status)) { > return Status; > } > - DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p with %r\n", IsRead ? "Read " : "Write", Partition->PartitionType, Lba, BlockNum, (Token != NULL) ? Token->Event : NULL, Status)); > + DEBUG ((DEBUG_BLKIO, > + "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p with %r\n", > + IsRead ? "Read " : "Write", Partition->PartitionType, Lba, BlockNum, > + (Token != NULL) ? Token->Event : NULL, Status)); > > Lba += BlockNum; > Buffer = (UINT8*)Buffer + BufferSize; > Reviewed-by: Laszlo Ersek