From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.1042.1578082152677214760 for ; Fri, 03 Jan 2020 12:09:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YK6owDLT; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578082151; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1CcjTmZIt3ytXTptcZIrr2VhG5jqhWYs90gzc1xx+jw=; b=YK6owDLTKFM8Wbpfg4qc6k4M6XeyuDPmbesO2PbpjZt1VdVBFJ7s5Q/0p7KtMVQp45tZmB UHzQx/jp+U2kjg8vkgWjx9cIMbLaW1GsJUJ4K1O1J6g/6j5WAlBzUXUi/9Hoj3vcBDq3ah KMeLrYz+DIWQt1PyUES+BU6zflqM6Rk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-Nl0bzUyYMPKIPX87kckfaA-1; Fri, 03 Jan 2020 15:09:08 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CA2BF182B796; Fri, 3 Jan 2020 20:09:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-245.ams2.redhat.com [10.36.116.245]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A49E68865; Fri, 3 Jan 2020 20:09:04 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v5 0/6] Microcode related optimizations From: "Laszlo Ersek" To: "Wu, Hao A" , "Ni, Ray" , "Dong, Eric" , "devel@edk2.groups.io" Cc: "Zeng, Star" , "Fu, Siyuan" , "Kinney, Michael D" Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20191231004914.8520-1-hao.a.wu@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C3D0651@SHSMSX104.ccr.corp.intel.com> <93c482ce-808d-4257-dc49-c60b1ec03059@redhat.com> Message-ID: <6fa00014-d907-4961-f5d7-0c2f7cbe1b62@redhat.com> Date: Fri, 3 Jan 2020 21:09:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <93c482ce-808d-4257-dc49-c60b1ec03059@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: Nl0bzUyYMPKIPX87kckfaA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Hello Hao, On 01/02/20 16:07, Laszlo Ersek wrote: > On 01/02/20 04:12, Wu, Hao A wrote: >> Ray and Eric, thanks a lot for the review. >> >> Hello Laszlo, >> It seems that you are out of office, I plan to push the series without your >> comments first. If you have feedbacks/comments with regard to the series, I >> will follow up for the potential refine/revert of the series. > > Just returned today. I'm now working to regain control of my mailbox. > > The above procedure works fine for me; in fact I would have suggested it > myself. In case I encounter a regression with OVMF, I'll report it. I've now run some regression tests [*], with OVMF built at commit b948a496150f ("UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer", 2020-01-02). At that stage, the tree contains your present patch series too (which ends at commit fd30b0070773). [*] Including, but a bit more than, . Basically my usual Linux guest tests. I haven't noticed any regressions. Thanks! Laszlo