From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web09.102.1583451918288059479 for ; Thu, 05 Mar 2020 15:45:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F4o6eQUU; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583451917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0JqATxO/jOHvomtg6FGcKeyARXgrWIf6M9xfCxwT0yA=; b=F4o6eQUUFJuBkgeBiqnbC9auX80HJfxI3iNXPLPVnAftxOqN/vQSIGgOmlfsj1jmmKOrmU Mgu5SLzhtPiBGaGJZCf+vfmrQMFS6qB54tP7PWl2xB78InX12HgQj8GJgdBQAeMJjJ1kqh y8L18WKGDgKgVHmaVugeG+egRCTWS7w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-5dhsF2HfPuO147bOp_oPgQ-1; Thu, 05 Mar 2020 18:45:15 -0500 X-MC-Unique: 5dhsF2HfPuO147bOp_oPgQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C5F141005509; Thu, 5 Mar 2020 23:45:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-216.ams2.redhat.com [10.36.117.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30C9A3A4; Thu, 5 Mar 2020 23:45:13 +0000 (UTC) Subject: Re: [PATCH] OvmfPkg/OvmfXen: fix build by providing QemuLoadImageLib resolution To: Ard Biesheuvel , devel@edk2.groups.io References: <20200305212652.27649-1-ard.biesheuvel@linaro.org> From: "Laszlo Ersek" Message-ID: <6fb9c2b1-893c-f23e-f968-374815196c8a@redhat.com> Date: Fri, 6 Mar 2020 00:45:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200305212652.27649-1-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/05/20 22:26, Ard Biesheuvel wrote: > Commit 859b55443a4253ba ("OvmfPkg/PlatformBootManagerLib: switch to > QemuLoadImageLib") replaced a dependency on LoadLinuxLib with one on > QemuLoadImageLib in the PlatformBootManagerLib implementation that is > shared between all OVMF builds, without taking into account that even > the Xen targeted builds incorporate this code, which is only used to > load kernels passed via the QEMU command line. > > Since this is dead code on Xen, we can satisfy the dependency using > the generic version of QemuLoadImageLib, which does not rely on > LoadLinuxLib, which we can therefore drop from OvmfXen.dsc. > > Fixes: 859b55443a4253bad8bb618d04a51b2ded67f24b > Signed-off-by: Ard Biesheuvel > --- > OvmfPkg/OvmfXen.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index d476694b18d5..85fe39f7896c 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -151,7 +151,7 @@ [LibraryClasses] > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > SerializeVariablesLib|OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf > QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf > - LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf > + QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.inf > MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/BaseMemEncryptSevLib.inf > LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > Reviewed-by: Laszlo Ersek Thanks for the quick fix! Laszlo