From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 241EC2118EF44 for ; Fri, 9 Nov 2018 00:04:49 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A1C6430821ED; Fri, 9 Nov 2018 08:04:48 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-96.rdu2.redhat.com [10.10.120.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B167100194A; Fri, 9 Nov 2018 08:04:47 +0000 (UTC) To: "Zhang, Chao B" , edk2-devel@lists.01.org Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Yao Jiewen References: <20181109060202.19340-1-chao.b.zhang@intel.com> From: Laszlo Ersek Message-ID: <6fc3b257-156a-21bf-ef1c-c4f04edf914d@redhat.com> Date: Fri, 9 Nov 2018 09:04:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181109060202.19340-1-chao.b.zhang@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 09 Nov 2018 08:04:48 +0000 (UTC) Subject: Re: [Patch] SecurityPkg: Fix TPM device compatibility issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 08:04:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/09/18 07:02, Zhang, Chao B wrote: > Issue Statement: > TPM InterfaceId cache feature is introduced by f15cb995bb3880b77e15afe6facd3da05e599a17. It follows TCG PTP spec 1.3 > to improve TPM transmission performance and also addresses defects in some TPM2.0 devices. But some other TPM devices like > NTC1310 SPI TPM is found function abnormally with this feature, causing extra device compatibility issue. > > Solution: > Add a policy indicator in PcdActiveTpmInterfaceType to disable TPM interface ID cache to support those existing TPM devices > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhang, Chao B > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Yao Jiewen > --- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 23 +++++++++++- > SecurityPkg/SecurityPkg.dec | 3 +- > SecurityPkg/SecurityPkg.uni | 3 +- > SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 49 +++++++++++++++++++++++++ > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 42 +++++++++++++++++++++ > 5 files changed, 117 insertions(+), 3 deletions(-) I'll let others review this patch for technical merit. However, I'm really undecided whether this patch qualifies for being pushed during the hard feature freeze. Comments welcome. Thanks Laszlo