From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5DC017803D1 for ; Tue, 5 Mar 2024 07:34:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lwHEFb4NO+e/8t5sdnKq3lhd7IZrIrFLduQPtH+GCmg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709624045; v=1; b=laykHBqKRjP703mbQgf+dxixrpBOjE/uXaS+S/p/cBCYC6tRGCipQSO46d35zvjGaM1wvMAc 6M+hklYLCV89uN4/Mh3HJpZ51SwDizvQlsoMWa5Sv3s+e7uAzx7B9k15W0+HU7n9Cp1DTVNnf2O 6H/Yf7gMiMRoXOMFM/ZV62iI= X-Received: by 127.0.0.2 with SMTP id L5OqYY7687511xJle5dATiVD; Mon, 04 Mar 2024 23:34:05 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.16682.1709624044996365114 for ; Mon, 04 Mar 2024 23:34:05 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-pnqVAgmLOte6CdRd2UBOmQ-1; Tue, 05 Mar 2024 02:34:00 -0500 X-MC-Unique: pnqVAgmLOte6CdRd2UBOmQ-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 16FD781A262; Tue, 5 Mar 2024 07:34:00 +0000 (UTC) X-Received: from [10.39.193.2] (unknown [10.39.193.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A89A28173; Tue, 5 Mar 2024 07:33:58 +0000 (UTC) Message-ID: <6fd2dded-3b45-100e-605a-653de6d1b257@redhat.com> Date: Tue, 5 Mar 2024 08:33:57 +0100 MIME-Version: 1.0 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MSAxLzFdIE1kZU1vZHVsZVBrZzogV2FybiBpZiBvdXQgb2YgZmxhc2ggc3BhY2Ugd2hlbiB3cml0aW5nIHZhcmlhYmxlcw==?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, osteffen@redhat.com Cc: 'Bob Feng' , 'Rebecca Cran' , 'Yuwei Chen' , 'Gerd Hoffmann' References: <20240304151805.129004-1-osteffen@redhat.com> <20240304151805.129004-2-osteffen@redhat.com> <004401da6e95$ac5d9e90$0518dbb0$@byosoft.com.cn> From: "Laszlo Ersek" In-Reply-To: <004401da6e95$ac5d9e90$0518dbb0$@byosoft.com.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WyEVLXRZalKnT5OIWLaoxkVcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=laykHBqK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 3/5/24 01:40, gaoliming via groups.io wrote: > Oliver: > If there is no enough space, Variable driver will reclaim flash and > reserve the enough space at boot time. What if the flash is genuinely fully occupied by *live* non-volatile variables? Laszlo > At the runtime, reclaim will not be trigged. The space may be out of > resource. The warning message may be reported. Is this your case? > > Thanks > Liming >> -----邮件原件----- >> 发件人: devel@edk2.groups.io 代表 Oliver Steffen >> 发送时间: 2024年3月4日 23:18 >> 收件人: devel@edk2.groups.io >> 抄送: Oliver Steffen ; Bob Feng >> ; Liming Gao ; Rebecca >> Cran ; Yuwei Chen ; Gerd >> Hoffmann ; Laszlo Ersek >> 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space >> when writing variables >> >> Emit a DEBUG_WARN message if there is not enough flash space left to >> write/update a variable. This condition is currently not logged >> appropriately in all cases, given that full variable store can easily >> render the system unbootable. >> This new message helps identifying this condition. >> >> Cc: Bob Feng >> Cc: Gerd Hoffmann >> Cc: Laszlo Ersek >> Cc: Liming Gao >> Cc: Rebecca Cran >> Cc: Yuwei Chen >> >> Signed-off-by: Oliver Steffen >> --- >> MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c >> b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c >> index d394d237a53f..1c7659031dc5 100644 >> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c >> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c >> @@ -2364,6 +2364,8 @@ UpdateVariable ( >> ); >> >> ASSERT_EFI_ERROR (Status); >> >> } >> >> + } else if (Status == EFI_OUT_OF_RESOURCES) { >> >> + DEBUG ((DEBUG_WARN, "UpdateVariable failed: Out of flash >> space\n")); >> >> } >> >> >> >> return Status; >> >> -- >> 2.44.0 >> >> >> >> >> > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116354): https://edk2.groups.io/g/devel/message/116354 Mute This Topic: https://groups.io/mt/104735640/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-