From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ECDF9740034 for ; Mon, 26 Feb 2024 13:59:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TNQ556cgBM58MVSbdxBeIR+S8bqY5tRnN2SmrlGjmzc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708955994; v=1; b=l6nL+2qPgPogOayxWmNkyHwnR1cLLtUN/sJvN0EszlZf6ahjnNC6U8/0lMkkxwj1iDBqspbA HdO42GDFDcMKIRSrpgMRvoBKp1SpnLDNt3JoRqw7YAEYH1889LuB0epEbjWM6YafQ0dyjoyWoVZ 6b33LSqC5k8jddlv+Je2x8hs= X-Received: by 127.0.0.2 with SMTP id OkOaYY7687511x9PYbn33g5N; Mon, 26 Feb 2024 05:59:54 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.20630.1708955993914487854 for ; Mon, 26 Feb 2024 05:59:54 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-fW87JUfEOEGD2fANc_4yZg-1; Mon, 26 Feb 2024 08:59:49 -0500 X-MC-Unique: fW87JUfEOEGD2fANc_4yZg-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8145985A58B; Mon, 26 Feb 2024 13:59:49 +0000 (UTC) X-Received: from [10.39.194.99] (unknown [10.39.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86C1C2166B33; Mon, 26 Feb 2024 13:59:48 +0000 (UTC) Message-ID: <6fd3d136-f6e1-0f7a-2b11-704c6554cfc4@redhat.com> Date: Mon, 26 Feb 2024 14:59:47 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber() To: devel@edk2.groups.io, ray.ni@intel.com, Gerd Hoffmann Cc: "Kumar, Rahul R" , Oliver Steffen References: <20240222160106.686484-1-kraxel@redhat.com> <20240222160106.686484-7-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5EbU1itlGv0QTWFRwU643Vl2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=l6nL+2qP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/23/24 03:33, Ni, Ray wrote: >> + ASSERT (FALSE); >=20 > How about ASSERT (EFI_NOT_FOUND)? Which is more meaningful than FALSE. I'll edit the patch -- assuming you mean ASSERT_EFI_ERROR (EFI_NOT_FOUND); Laszlo >=20 > No matter you change or not, Reviewed-by: Ray Ni >=20 >> + return 0; >> } >> >> /** >> -- >> 2.43.2 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115964): https://edk2.groups.io/g/devel/message/115964 Mute This Topic: https://groups.io/mt/104510913/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-