Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned

["Oliver Smith-Denny" <osde@linux.microsoft.com>]

On 2/5/2024 9:22 AM, Rebecca Cran via groups.io wrote:
> On 2/2/2024 5:59 PM, Oliver Smith-Denny wrote:
> 
>> Ok, got sidetracked, but got back to this. Rebecca, can you create a
>> bugzilla for this and try this patch:
>>
>> https://github.com/tianocore/edk2/pull/5339.
>>
>> I want to get some feedback on it and your testing before I send out a
>> patch for it. However, it did fix my repro case where I was failing to
>> free runtime memory with page guard enabled, so I believe it should fix
>> your case.
>>
>> I need to fix some minor things like patch check, etc. I also did my
>> testing on a slightly old version of master, so may need a minor touch
>> up.
> 
> I've created https://bugzilla.tianocore.org/show_bug.cgi?id=4674 .
> 
> I cherry-picked your commit into my tree but unfortunately I now get a 
> crash earlier:
> 
> Loading driver at 0x000F3AA0000 EntryPoint=0x000F3AB1514 
> StatusCodeHandlerRuntimeDxe.efi
> InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF F3BFEFD0
> ProtectUefiImageCommon - 0xF3CA0E98
>    - 0x00000000F3AA0000 - 0x0000000000030000
> ConvertPages: range F3ADF000 - F3AF0FFF covers multiple entries
> ConvertPages: range F3ADF000 - F3AEFFFF covers multiple entries
> ConvertPages: range F3ADF000 - F3AEFFFF covers multiple entries
> 
> 
> Synchronous Exception at 0x00000000FB8928E4
> PC 0x0000FB8928E4 (0x0000FB886000+0x0000C8E4) [ 0] DxeCore.dll
> PC 0x0000FB8A4798 (0x0000FB886000+0x0001E798) [ 0] DxeCore.dll
> PC 0x0000FB898798 (0x0000FB886000+0x00012798) [ 0] DxeCore.dll
> PC 0x0000F3AB1944 (0x0000F3AA0000+0x00011944) [ 1] 
> StatusCodeHandlerRuntimeDxe.dll
> PC 0x0000FB88D8F0 (0x0000FB886000+0x000078F0) [ 2] DxeCore.dll
> PC 0x0000FB899EEC (0x0000FB886000+0x00013EEC) [ 2] DxeCore.dll
> PC 0x0000FB89123C (0x0000FB886000+0x0000B23C) [ 2] DxeCore.dll
> 

Well that's a bummer :). I moved to top of tree edk2 and added
StatusCodeHandlerRuntimeDxe to the ArmVirtQemu build and I am
not seeing your crash. Do you have any PCDs set for this driver?

I am running with the HeapGuard PCDs you sent before:

gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0F
gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPageType|0xC00000000000FFFF
gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPoolType|0xC00000000000FFFF

However, I am seeing a crash when the shell launches now, so I will
debug this. Something changed in the upstream, probably exposing a bug
in my code. Let's see if it is the same thing as you are seeing.

Thanks,
Oliver


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115124): https://edk2.groups.io/g/devel/message/115124
Mute This Topic: https://groups.io/mt/103810212/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-