From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mx.groups.io with SMTP id smtpd.web11.13925.1677640984976631868 for ; Tue, 28 Feb 2023 19:23:05 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=t6mhiUq7; spf=pass (domain: bsdio.com, ip: 64.147.123.21, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id CC7BA32007CF; Tue, 28 Feb 2023 22:23:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 28 Feb 2023 22:23:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1677640981; x= 1677727381; bh=O6WIuSAgzQwxUo9ZHuyOJg2vWw0eRuZ/fhAHi4b00RM=; b=t 6mhiUq746DvYamblwgBrJ+3O/RidZpRTw693t5Bo4F0Mma5c0gQg++TWTFWZzx3J b4G5Da+f5Kf8BglhQS/T41zojuXva6F/sGiOsO2FUXfUQXk+U0RR/TbA6SaKGhQK syB0HsxXqXye9XhVeZ3m9FLQEetFPZy7vTvZBSfaol5CCNeiwuUJ/qxYmiGCGVVD UE/0kRpKQfABc9S8x3lfxpC9JkaHX8DWwL88LQMGPW6JrCwyGYOFJuIjnjmJEP/D d/ET6HGlow5UH5JEA3T0vVSIhGr74NLkzo+xva0UCnQY9ousbe191UOFHBuZGQIw 89kqGZmbY16UFk5yPrlpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677640981; x= 1677727381; bh=O6WIuSAgzQwxUo9ZHuyOJg2vWw0eRuZ/fhAHi4b00RM=; b=E 7Y9WjWugSfL6LnEza8KkU25nUditVKVQr4UG4msn8X8vhozmTX61Uzhh0UUxCkdS wcjTKIsQ7a+jPNDy+fqTx17kS3psJaY7Y+NBnjchW3Lg9RxdsaoyANjDPXtDyOHk iXltNOkuaJvYOtUCggctzFwbOTX/VTWZ7NJrGQ4EPpyHN9jNI2FVJE+XleSdPOiN DusIJTduh45OFTd8MJeSYtpMHVFhs8DYlxlNhLSQLqrJmVaw+zImWR2JMuSgf5lX N6N9dyE/hmn9EMZqggFRdv3Z/GFZ/iJqDphSjr8f26XrtTdeXYfRQ7/f5aYF4m8O NV0/5/CN1zMs9iWXoGl0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelgedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeelkeeihfeiudeludeitefgkeehteehveegfeetfeelvdelfefhvedvgeeh uedtkeenucffohhmrghinhepvgguihhtohhrtghonhhfihhgrdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghs ughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Feb 2023 22:23:00 -0500 (EST) Message-ID: <6fe90ba4-7848-a6fb-8263-6cb0af790331@bsdio.com> Date: Tue, 28 Feb 2023 20:22:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details To: "Kinney, Michael D" , Ard Biesheuvel , "devel@edk2.groups.io" Cc: Andrew Fish , Leif Lindholm References: <20230227034702.82215-1-rebecca@bsdio.com> <4c6db5b3-57ad-e3e3-9074-98741b7fd4fb@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mike, It looks like the line endings and tab/spaces of .gitmodules doesn't matter: do we still want to list a preference for it? "Given the following, I'm not sure line endings matter at all to git? $ file .gitmodules .gitmodules: ASCII text, with CRLF, LF line terminators $ file .gitignore .gitignore: ASCII text, with CRLF line terminators There's a CRLF in .gitmodules at the end of the brotli section. We could certainly specify that LF is _preferred_ for all .git files though?" On 2/28/23 2:32 PM, Kinney, Michael D wrote: > What about .gitmodules? > > Mike > >> -----Original Message----- >> From: Rebecca Cran >> Sent: Tuesday, February 28, 2023 10:21 AM >> To: Kinney, Michael D ; Ard Biesheuvel ; devel@edk2.groups.io >> Cc: Andrew Fish ; Leif Lindholm >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >> >> Before I sent out an official v2 patch, does the following look good? >> >> >> diff --git a/.editorconfig b/.editorconfig >> new file mode 100644 >> index 000000000000..587d5bbaa884 >> --- /dev/null >> +++ b/.editorconfig >> @@ -0,0 +1,31 @@ >> +# EditorConfig file: https://EditorConfig.org >> + >> +root = true >> + >> +[*] >> +charset = latin1 >> +end_of_line = crlf >> +indent_style = space >> +indent_size = 2 >> +insert_final_newline = true >> +trim_trailing_whitespace = true >> + >> +[*.py] >> +charset = utf-8 >> +indent_style = space >> +indent_size = 4 >> + >> +[*.sh] >> +end_of_line = lf >> + >> +[.gitattributes] >> +end_of_line = lf >> + >> +[.mailmap] >> +charset = utf-8 >> + >> +[Maintainers.txt] >> +charset = utf-8 >> + >> +[Makefile,GNUmakefile] >> +indent_style = tab >> >> >> -- >> Rebecca Cran >> >> >> On 2/27/23 11:23 AM, Kinney, Michael D wrote: >>> .gitmodules also must also use tabs. >>> >>>> -----Original Message----- >>>> From: Kinney, Michael D >>>> Sent: Monday, February 27, 2023 10:22 AM >>>> To: Ard Biesheuvel ; devel@edk2.groups.io; rebecca@bsdio.com >>>> Cc: Andrew Fish ; Leif Lindholm ; Kinney, Michael D >>>> Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>> >>>> .gitmodules must be lf. Not sure about other git config files. >>>> >>>> Mike >>>> >>>>> -----Original Message----- >>>>> From: Ard Biesheuvel >>>>> Sent: Monday, February 27, 2023 10:18 AM >>>>> To: devel@edk2.groups.io; rebecca@bsdio.com >>>>> Cc: Kinney, Michael D ; Andrew Fish ; Leif Lindholm >>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>>> >>>>> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran wrote: >>>>>> Is it just .sh files that need lf endings, or are there others? >>>>>> >>>>> I think this only applies to .sh files. >>>>> >>>>>> On 2/27/23 9:14 AM, Michael D Kinney wrote: >>>>>>> There are a few file types that must be lf instead of crlf. Can those be added as well? >>>>>>> >>>>>>> Mike >>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: devel@edk2.groups.io On Behalf Of Rebecca Cran >>>>>>>> Sent: Monday, February 27, 2023 5:03 AM >>>>>>>> To: Ard Biesheuvel ; devel@edk2.groups.io >>>>>>>> Cc: Andrew Fish ; Leif Lindholm ; Kinney, Michael D >>>>> >>>>>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>>>>>> >>>>>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: >>>>>>>> >>>>>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran wrote: >>>>>>>>>> Add a .editorconfig file which editors can use for basic formatting >>>>>>>>>> details of files, such as tabs/spaces, line endings etc. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Rebecca Cran >>>>>>>>> Thank you very much for this - this is very useful. >>>>>>>>> >>>>>>>>> Acked-by: Ard Biesheuvel >>>>>>>>> >>>>>>>>> Could we add .dsc/.inf/.dec/etc files as well? >>>>>>>> I'll move the c/c++ indentation up to the [*] section so it applies to >>>>>>>> .dsc/.inf/etc too. >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Rebecca Cran >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>>