From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E7185D811B2 for ; Wed, 17 Jan 2024 15:16:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MG3WEmCnwHnTwFdZ0D0CXmPcwM0BlAToH6kiZF9sC5w=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1705504577; v=1; b=EuZL/Jj6LJcyNibAnOFK7u9O21yfj9Mc1MhPGzzyuny/SFewvxIQDJFudIPjQSVL1xHobL0Z OuIZxaV/wRUteD2j8rlT8jEqWeX347mDsoYDA0pB2w/FIwlXRALNAQOlyby83MCDGuMGguv9zzb KfQkTvDu70RqPKbmiCGtbyNQ= X-Received: by 127.0.0.2 with SMTP id u7U3YY7687511xSv7ohR63dF; Wed, 17 Jan 2024 07:16:17 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.4973.1705504576854448019 for ; Wed, 17 Jan 2024 07:16:17 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-6t9CAV98PvyDASghoHpt-Q-1; Wed, 17 Jan 2024 10:16:12 -0500 X-MC-Unique: 6t9CAV98PvyDASghoHpt-Q-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3D66F86C045; Wed, 17 Jan 2024 15:16:12 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 15736492BC6; Wed, 17 Jan 2024 15:16:12 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DCB911800DC8; Wed, 17 Jan 2024 16:16:10 +0100 (CET) Date: Wed, 17 Jan 2024 16:16:10 +0100 From: "Gerd Hoffmann" To: Abdul Lateef Attar Cc: devel@edk2.groups.io, Abdul Lateef Attar , Ray Ni , Rahul Kumar Subject: Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu topology Message-ID: <6n74ynm4bswoix5naeo4lcbsyled6b3ekirjtquyvup5y565fr@mnl3hqx4lkl3> References: <64839533d33fb34b1568d78d26c5e7900c40cad5.1705484942.git.AbdulLateef.Attar@amd.com> MIME-Version: 1.0 In-Reply-To: <64839533d33fb34b1568d78d26c5e7900c40cad5.1705484942.git.AbdulLateef.Attar@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PzhsZbPTQhZ8ZqfqRgGRDqlrx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="EuZL/Jj6"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) > + /// Check if extended toplogy supported > + AsmCpuid (CPUID_EXTENDED_FUNCTION, &MaxExtendedCpuIdIndex, NULL, NULL, NULL); > + if (MaxExtendedCpuIdIndex >= AMD_CPUID_EXTENDED_TOPOLOGY) { > + do { > + AsmCpuidEx ( > + AMD_CPUID_EXTENDED_TOPOLOGY, > + TopologyLevel, > + &ExtendedTopologyEax.Uint32, > + &ExtendedTopologyEbx.Uint32, > + &ExtendedTopologyEcx.Uint32, > + NULL > + ); > + > + if (ExtendedTopologyEbx.Bits.LogicalProcessors == CPUID_EXTENDED_TOPOLOGY_LEVEL_TYPE_INVALID) { Comparing LogicalProcessors with CPUID_EXTENDED_TOPOLOGY_LEVEL_TYPE_* looks wrong, even though it probably works due to CPUID_EXTENDED_TOPOLOGY_LEVEL_TYPE_INVALID being zero ... > + /// if this fails at first level > + /// then will fall back to non-extended topology > + break; > + } > + } while (ExtendedTopologyEbx.Bits.LogicalProcessors != CPUID_EXTENDED_TOPOLOGY_LEVEL_TYPE_INVALID); Same here. Also this will never be false because the check above already quits the loop in that case, so you can simplify this to "while (true)". take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113954): https://edk2.groups.io/g/devel/message/113954 Mute This Topic: https://groups.io/mt/103782768/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-