public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	 "lersek@redhat.com" <lersek@redhat.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	 "Kim, Dongwon" <dongwon.kim@intel.com>
Subject: Re: [edk2-devel] [PATCH v1] OvmfPkg/PlatformInitLib: Don't override user specified PciMmio64Size
Date: Tue, 7 Nov 2023 11:26:40 +0100	[thread overview]
Message-ID: <6qjwf75ofb3suruqe4dliujih74nxxpw2xyekxwtjrgzwvwd46@4rygctstz472> (raw)
In-Reply-To: <IA0PR11MB71859F1A439E5582EBFE5053F8A9A@IA0PR11MB7185.namprd11.prod.outlook.com>

  Hi,

> > Strictly speaking you don't care that much about the size of the mmio
> > window, but where it gets placed.  Moving it to the end of the vcpu
> > address space is what breaks your use case in case the iommu address
> > space happens to be too small for that.
> Right, the crux of the problem is indeed the placement of the window
> and not the size. Given this, do you see any problem if the mmio window
> were to be placed at the lower end of the address space?

That might still not work because OVMF scales the window size with the
address space.

> Or, do you think
> ensuring that PhysMemAddressWidth = <IOMMU address width>
> automatically via Qemu/OVMF like Laszlo suggested is a better solution
> for this problem?

The best temporary stop gap IMHO is using 

  -cpu host-phys-bits=on,host-phys-bits-limit=<iommu-address-bits>

Side note: The qemu master branch has a precompiled seabios version
which also does iommu window scaling and will need the same treatment.

How to solve that long-term should be discussed on the qemu-devel list.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110835): https://edk2.groups.io/g/devel/message/110835
Mute This Topic: https://groups.io/mt/102359124/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-11-07 10:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-03  5:15 [edk2-devel] [PATCH v1] OvmfPkg/PlatformInitLib: Don't override user specified PciMmio64Size Vivek Kasireddy
2023-11-03 13:15 ` Laszlo Ersek
2023-11-03 14:07   ` Laszlo Ersek
2023-11-06 11:47     ` Gerd Hoffmann
2023-11-07  5:42       ` Vivek Kasireddy
2023-11-07 10:26         ` Gerd Hoffmann [this message]
2023-11-08  6:24           ` Vivek Kasireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6qjwf75ofb3suruqe4dliujih74nxxpw2xyekxwtjrgzwvwd46@4rygctstz472 \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox