From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.51197.1681726665407691558
 for <devel@edk2.groups.io>;
 Mon, 17 Apr 2023 03:17:45 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a3TG3sxL;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1681726664;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=iFGVpLJy5yIf16j3485opcqSQ0nchaAs29Ts8aDFmlE=;
	b=a3TG3sxLaXU32s1Ey7pQ3p0/3poz1Htuk649cclYdxtMcOEod5/1qCtc29pJm/mFEYuFsJ
	cNAhYi1au4QmKN8jGBQgCtLV9ePzdbb7wlaEYuAPY76t420ciD5VSTr9nvRZL7Js/f0vx5
	bjTwuR1pM8upbqCb2kQDJx06Dy0SF3I=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-180-7itssm-RPGi4a8o_iraULg-1; Mon, 17 Apr 2023 06:17:39 -0400
X-MC-Unique: 7itssm-RPGi4a8o_iraULg-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C931738149A5;
	Mon, 17 Apr 2023 10:17:38 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.149])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 825FD2166B26;
	Mon, 17 Apr 2023 10:17:38 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 8027618000B3; Mon, 17 Apr 2023 12:17:36 +0200 (CEST)
Date: Mon, 17 Apr 2023 12:17:36 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, osteffen@redhat.com, 
	Anthony Perard <anthony.perard@citrix.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen <jordan.l.justen@intel.com>, 
	Julien Grall <julien@xen.org>, Leif Lindholm <quic_llindhol@quicinc.com>, 
	Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>, 
	Zhichao Gao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line
Message-ID: <6sqoamwfqxkm35ff7zu4cnrta6utsgoet5ai3jt6truy6rcez3@2at3rzewmg2q>
References: <20230414083323.153731-1-osteffen@redhat.com>
 <45cf5684-fb48-abf7-a3d6-997f4b9c108d@bsdio.com>
MIME-Version: 1.0
In-Reply-To: <45cf5684-fb48-abf7-a3d6-997f4b9c108d@bsdio.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 14, 2023 at 06:13:03AM -0600, Rebecca Cran wrote:
> Sorry for not commenting on this earlier.
> 
> Would it be better to have people use the build `--pcd` option instead? e.g.
> build --pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302".

Possible, but the syntax is not that simple, you need 'L' prefix (so
CHAR16 not CHAR8 is used) and '\0' postfix (so the string is properly
terminated), i.e. --pcd=PcdFirmwareVersionString="L${version}\\0".

Providing a shorter and less error prone way to specify the version
looks sensible to me.

take care,
  Gerd