public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v4 0/2] Set Firmware Version from build command line
@ 2023-04-14  8:33 Oliver Steffen
  2023-04-14  8:33 ` [PATCH v4 1/2] OvmfPkg: allow setting " Oliver Steffen
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Oliver Steffen @ 2023-04-14  8:33 UTC (permalink / raw)
  To: devel
  Cc: Anthony Perard, Ard Biesheuvel, Gerd Hoffmann, Jiewen Yao,
	Jordan Justen, Julien Grall, Leif Lindholm, Ray Ni, Sami Mujawar,
	Zhichao Gao, Oliver Steffen

ArmVirtXen.dsc allows setting the firmware version
string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
via FIRMWARE_VER variable conveniently on the build command line.

These two patches add this behavior to all .dsc files in ArmVirtPkg
and OvmfPkg.

PR: https://github.com/tianocore/edk2/pull/4268

v4:
- Actually use the include file

v3:
- Introduce common include file for OVMF .dsc files
https://edk2.groups.io/g/devel/message/102952

v2:
Address comments by Sami and Gerd:
- Only set PCD if FIRMWARE_VER is defined
- ArmVirt: move logic to ArmVirt.dsc.inc
https://edk2.groups.io/g/devel/message/95208

v1:
https://edk2.groups.io/g/devel/message/95057

Oliver Steffen (2):
  OvmfPkg: allow setting Firmware Version from build command line
  ArmVirtPkg: allow setting Firmware Version from build command line

 ArmVirtPkg/ArmVirt.dsc.inc          | 4 ++++
 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++
 ArmVirtPkg/ArmVirtXen.dsc           | 1 -
 OvmfPkg/OvmfPkgIa32.dsc             | 2 ++
 OvmfPkg/OvmfPkgIa32X64.dsc          | 2 ++
 OvmfPkg/OvmfPkgX64.dsc              | 3 +++
 OvmfPkg/OvmfXen.dsc                 | 2 ++
 7 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc

-- 
2.40.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-05-04 10:55 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-14  8:33 [PATCH v4 0/2] Set Firmware Version from build command line Oliver Steffen
2023-04-14  8:33 ` [PATCH v4 1/2] OvmfPkg: allow setting " Oliver Steffen
2023-04-14  8:33 ` [PATCH v4 2/2] ArmVirtPkg: " Oliver Steffen
2023-04-14 12:13 ` [edk2-devel] [PATCH v4 0/2] Set " Rebecca Cran
2023-04-17 10:17   ` Gerd Hoffmann
2023-04-17 14:23     ` Rebecca Cran
2023-05-04 10:13 ` Gerd Hoffmann
2023-05-04 10:55   ` [edk2-devel] " Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox