From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.11355.1687270421245213584
 for <devel@edk2.groups.io>;
 Tue, 20 Jun 2023 07:13:41 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EKLdGkUG;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1687270420;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=j2y0ygZeUtGs7z6NEqAmCIvdxNN6fvICqHSHMnwlBTY=;
	b=EKLdGkUG8R2uZhYS4qSeaqS3ZfCINCGF4gJ8eWjSrTlsW4QcUri1LfjnQhcHspye416Djc
	yH0mrcBdwJv7XHCcH0r+rO7pkSNjei3KHPqnGhHBgmq930vR56BxEMd16UaQkYvm27dazK
	WeNoNEdOLseHTN9jFFSBFjAa3ZJUrmA=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-390-hORDzNeXM-e7KRbN-nu2Lw-1; Tue, 20 Jun 2023 10:13:29 -0400
X-MC-Unique: hORDzNeXM-e7KRbN-nu2Lw-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 008CD1064FB6;
	Tue, 20 Jun 2023 14:10:50 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.126])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id C9AA7492B01;
	Tue, 20 Jun 2023 14:10:49 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 8844A1803082; Tue, 20 Jun 2023 16:10:48 +0200 (CEST)
Date: Tue, 20 Jun 2023 16:10:48 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, yuanhao.xie@intel.com
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>, 
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/5] UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop.
Message-ID: <6wlb63465sjdrac2ilgfalnshfgfn6wi7zlak72tdyzwekl7p3@fp56m5kjjjry>
References: <20230612133720.15501-1-yuanhao.xie@intel.com>
 <20230612133720.15501-4-yuanhao.xie@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230612133720.15501-4-yuanhao.xie@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 12, 2023 at 09:37:18PM +0800, Yuanhao Xie wrote:
> Refactor the logic for placing APs in
> Mwait/Runloop into a separate function.

> +    // If AP start-up signal is written, AP is waken up
> +    // otherwise place AP in loop again
> +    //
> +    if ((*ApStartupSignalBuffer == WAKEUP_AP_SIGNAL) || (*ApStartupSignalBuffer == MP_HAND_OFF_SIGNAL)) {
> +      break;
> +    }

> -      // If AP start-up signal is written, AP is waken up
> -      // otherwise place AP in loop again
> -      //
> -      if (*ApStartupSignalBuffer == WAKEUP_AP_SIGNAL) {
> -        break;
> -      }

Nope.  This isn't refactoring.  Please split the patch into two, one
doing the refactoring without functional change, and one adding the code
for MP_HAND_OFF_SIGNAL.

take care,
  Gerd