From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 70C3094169B for ; Thu, 21 Dec 2023 13:54:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Bc1Jl5KQ97omUhHZUFyheBl/emF3VupbpBN3yqr68rQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20140610; t=1703166858; v=1; b=BUPZ7V6a8yZ3muq+nN1BOIJgrkooPYiHEpX3LLBeC9hodOQqSXXO3n3a3RF7h66OQaabBElw ib0Evjd2TvEJixRwBR1H+TDI/9Gz1/ftdofR5tBaXUtArvpJHWTWUMJ7G1ObsoN/h9RaFqyA6Ji XzuUY0gnI9rFs7kpXJbO2meY= X-Received: by 127.0.0.2 with SMTP id AE6EYY7687511x34eW59TjTh; Thu, 21 Dec 2023 05:54:18 -0800 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.70]) by mx.groups.io with SMTP id smtpd.web10.51636.1703166856877018400 for ; Thu, 21 Dec 2023 05:54:17 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TzAnD/GVH5gWS8ZIX3vWEBSVYrhgiCkvaWK/yG4R7wA0pUXxU+5DylZ2gv4vsdIb8eGkCiLOcBb0ZEZkSghxK6RXDwdRgwYJvsdqmAsqsKuutegsxNa9UwKo+3G1ksqx/d6UHOT4B73sL/J+H2wUdD1jYtWCaGhS0dybKjsv8aVsebWLY85zHtaXWah8BoX3kVNjZOUtxqWN84AustEyaaYv0aUNNnV8ZGNgLm4mA8RnJAjdkeT/4BN4i1KvWdQdF7vMIew7inpDhU2E293pA0n4/sCWX++s/ustJsX3+nI6aSUr8oxalnLh0hkGr2KeBFOFPiaxFMDns7y6nRugow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r2FbT0F6SKBixu2FXD0dMexqkRmuuVn5why1oySB9UQ=; b=gwOMufEe82/DzwmzsG1TbU+vzBeuh3pDflp3bteBkrPSnPtRheRjuoRTeF0pwBVc5JU2O+05zt+R8kE7GPfZd9s4FBqrdlOCTZYux02u/ezld9fIaLP03itbxEAIp7mI8oxMW0ZN5MmU4N9FF93RF0loH5BahMlfnc5Kck5wVjFmrL2/Y33Z0pOBi5Mc3FZKxeO3drBXi+mGjMnDooSsc/UdD5Vp97NstTLmNdVq21JkiTtzTrU9db4KFlAQfypspV2yKg2jIocUJ7IPociFo4bTNbUlTy7fvtavLEGlZ7XKdVbQ3hy7zinCO3qBORk2G+N2Kd5jY6ZDVWtrbQHymw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from DU2PR04CA0240.eurprd04.prod.outlook.com (2603:10a6:10:2b1::35) by GV1PR08MB7378.eurprd08.prod.outlook.com (2603:10a6:150:22::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.20; Thu, 21 Dec 2023 13:54:12 +0000 X-Received: from DB5PEPF00014B8C.eurprd02.prod.outlook.com (2603:10a6:10:2b1:cafe::18) by DU2PR04CA0240.outlook.office365.com (2603:10a6:10:2b1::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18 via Frontend Transport; Thu, 21 Dec 2023 13:54:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5PEPF00014B8C.mail.protection.outlook.com (10.167.8.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Thu, 21 Dec 2023 13:54:12 +0000 X-Received: ("Tessian outbound 26ee1d40577c:v228"); Thu, 21 Dec 2023 13:54:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e24abcb0c1731a13 X-CR-MTA-TID: 64aa7808 X-Received: from ccff92addd83.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3460E077-0D2E-48A2-B3CB-1835CA908A08.1; Thu, 21 Dec 2023 13:54:05 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ccff92addd83.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Dec 2023 13:54:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oHN6HGpf+m4746wi3pv3o2dKeR9s/oB9AHywzLTf2Srvt198AZEGSvZ/LTNpQ/rHUG7MkSQ1uJR4zX/KmTSeTl6c/NxyqS7jyHWPcxJeKhsc9vQ1fBrhsubAOwEV3gqJyuP7ja/O2HidyOfKnnEF7iQIWTksrncdyV/RB4P90MMvr4e/TcUD2Z8JWx0P9GLu1yB/SfEk0teF9Y03ggiLjAo0HNkGUS6ly4zLYp46NMZTsINRGh1h368p4HQl0ZPbrweQ8kVSlphvEHvgKMGjY8/tfvE4ynYL1Vr9vxLW/KDHfU9URZVb5nxH1wEC1jzBLWFuBJtk6COclUK8TlK34g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r2FbT0F6SKBixu2FXD0dMexqkRmuuVn5why1oySB9UQ=; b=YlC+NG1yQ0GL0ylMTsmoHwh5BxTE0OC6qkAdmowIta6ohfwkRa+S+x75x7cwvAfd7Y/yWQDz7/u8+/K0YuxMvJUr8WGFJReB9gxDNxheBL5+T5MxIpDWCXLAKKD4G2032t6rn1q7Irp6QS0mAyN9MT+y9mEkMd/fpBS5PhJrGLvfmW9egkQr06QOuiB80jl6Mv/LjvgntF0HQRIGGUm6n6HOPu4BeVAkiMHkIznEkevlUCzWBRZYICwQ15eKCBifBL7gC+nwaUp35mKUkR7Di2wkSu3qTO+m//bYfPZSXlq34b8S7VZC6v9w9Vkgs/WhAoSnnbyjqgRtrquAtwvqmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB10367.eurprd08.prod.outlook.com (2603:10a6:10:409::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Thu, 21 Dec 2023 13:54:02 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7113.019; Thu, 21 Dec 2023 13:54:02 +0000 Message-ID: <70080532-c3e4-4775-a2ed-b71117113872@arm.com> Date: Thu, 21 Dec 2023 13:54:01 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [Resend PATCH v5 3/4] DynamicTablesPkg: Corrects function pointer typedef of AML_PARSE_FUNCTION To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Abdul Lateef Attar , Pierre Gondois , "nd@arm.com" References: <7e4002c31255264cbd2daeaf854e4a1e6737c558.1703064925.git.AbdulLateef.Attar@amd.com> From: "Sami Mujawar" In-Reply-To: <7e4002c31255264cbd2daeaf854e4a1e6737c558.1703064925.git.AbdulLateef.Attar@amd.com> X-ClientProxiedBy: LO4P123CA0369.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::14) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU0PR08MB10367:EE_|DB5PEPF00014B8C:EE_|GV1PR08MB7378:EE_ X-MS-Office365-Filtering-Correlation-Id: 105cae8f-d20d-4aef-cfb9-08dc022c4fdb x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5wlFyGJlfcgGKuK7z6FHgvp+IGx4htf9L4LcXB1uuRTpz/XLgwLeCoC+QX+x9PdWbxb1B5QEbHGv32SBn1GT869rK1fgxOCClHpUDRSaXg7akJuW4TIu+DI/yyZgLVgC64OaEo2De7A2MyA9rh339MlFI5e+EEBBp98JtYfKfzNl9lCWFxhsnRSU8ROql3g9LBtZWTyEnlVcqDO1uiXibUuoUMHaIy2axrv+t3lekoLEtgj3CTjiXqZ4udUA0HKtTi1L6CBzqAXt6iH9hRDS5bUF31/YD6WI0CwhEA2F1a6ANdiwSN6GUSxE/ukArnqxOKJt2/LvzRdk7vjG5Lf+UzPZzfB4n7j0n8guI7o2yW7q++fSwQxGYHTrWrYy5FAGZaQ4i+FqM3SkeCw228hxvhO+QvxaszuwbkagHhrVlo/h1wzoDuvWF2yrdIFEa5UzXDXo4YvPrlTGa7IFJRIZWagjimBLLZh+mepboXab3sTqQ+LA/Amc+l25o889Kybz08eOkDI3h9CKgQa7V36hrRbSIM4fJeW6Z1DnG7aUr50dclBe4rnJFAPGvkpq0QzNPgUT2PcMDIjIbsFJZdGDIzpVM/GYC+eH2MNyCpuXC6AOG3Pk33qVuWP9QE8yNaJxe14V+WzmnGUBohT112xzCw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(346002)(39860400002)(366004)(396003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(31686004)(41300700001)(38100700002)(66556008)(2906002)(5660300002)(166002)(8936002)(66476007)(4326008)(8676002)(54906003)(316002)(66946007)(44832011)(31696002)(26005)(86362001)(966005)(6512007)(36756003)(83380400001)(6506007)(6486002)(2616005)(33964004)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB10367 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B8C.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 21cafa52-c98a-4651-d4b4-08dc022c4a0d X-Microsoft-Antispam-Message-Info: 4ClTiac7vXV9BO7189Ca6DY+VYVvgloLaA0Ce3GGhfgh749SlJfjKznGDyyuDN4JHgSXkwR55q0NpgZW+Ye8O1vJgdEr1g8II0swdmOMIELCkW4Z5kWhKMNE76pBC6n+tIMhVXvfv7j4DGQa4C7ryGvlmBeGYv77kDLVuheubUDAYpsXhparbqiD7i6QEglg21jNb/g2iVpxKrENfCD6jERKYSy7OPLHv1QwxjNCOoi7SC40WwYI0VsJlbVb8zxx3PoyJ13OwJa5eK4L1aHkWaNjdYvRBZN4McckI49KNm+osUWMT76zyOFp2zTCEPe0L97XQocPam56ZyfPpdRJz9lLAofDSTN4RwwGJhk8l7OoH5X5uXRYgmy5xS5ZJTcesyzm3Qps+bl2Y1bjuyY5WI8s6/ZFpjXhWvMySD078c8pvSkPHjsoXlPb80R2tP5wOAg305ltUwukvj5+ZcbNLpoq9eZle7fvScvkOlLWsscTXT4s3FmVEQTvdkN1ZzrlBPES3SUUCXVpkXEf6o99N7pytLn5KkPs1kiVkP63IedVA75BkI673/YoR14dmb952JwIW5VpIZ/tW2t2MNu4yDh+hBtqwMM22gyu4EcNpb4XTL1M4VNeSKiPO8kzOEGxPPYl40VO6r1Pq4d4ZsqPpz9dwdg5TaURTlSGlUKgZWVZx7LDmJk4+nNNkTB4PU3K/fnteLXqPsrOBhM7i5Q6213N3I+7dJAGblgnx/LeFcm3002lheiy6AfwyJ6qJuBe X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 13:54:12.1233 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 105cae8f-d20d-4aef-cfb9-08dc022c4fdb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B8C.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7378 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bRMeHsCxGHrb4L1QxO3Wu7E1x7686176AA= Content-Type: multipart/alternative; boundary="------------4PVkoQh2ufic94UdKwKtaRNc" Content-Language: en-GB X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BUPZ7V6a; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------4PVkoQh2ufic94UdKwKtaRNc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Abdul, Thank you for this fix. For Arm EFIAPI evaluates to nothing, hence we could not catch such issues. Do you use the rest of the Dynamic Tables Framework? I guess we have not=20 included the calling convention at other places e.g.=20 https://github.com/tianocore/edk2/blob/master/DynamicTablesPkg/Include/Acpi= TableGenerator.h#L217 Maybe we need to find and fix those issues as well. In either case, this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 20/12/2023 09:38 am, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar > > Corrects the function pointer typedef AML_PARSE_FUNCTION, > otherwise some compiler like VS2019 gives error. > > Cc: Pierre Gondois > Cc: Sami Mujawar > Signed-off-by: Abdul Lateef Attar > Reviewed-by: Pierre Gondois > --- > DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/= DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c > index 8e584d4930..d3a51a94c7 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c > @@ -100,8 +100,7 @@ AmlParseStream ( > **/ > typedef > EFI_STATUS > -EFIAPI > -(*AML_PARSE_FUNCTION) ( > +(EFIAPI *AML_PARSE_FUNCTION)( > IN CONST AML_NODE_HEADER *Node, > IN AML_PARSE_FORMAT ExpectedFormat, > IN OUT AML_STREAM *FStream, -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112816): https://edk2.groups.io/g/devel/message/112816 Mute This Topic: https://groups.io/mt/103278520/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------4PVkoQh2ufic94UdKwKtaRNc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Abdul,

Thank you for this fix.

For Arm EFIAP= I evaluates to nothing, hence we could not catch such issues.

Do you use the rest of the Dynamic Tables Framework? I guess we have not included the calling convention at other places e.g. https://g= ithub.com/tianocore/edk2/blob/master/DynamicTablesPkg/Include/AcpiTableGene= rator.h#L217

Maybe we need to find and fix those issues as well.

In either cas= e, this patch looks good to me.

Reviewed-by: = Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar<= /span>

On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar <=
;AbdulLateef.Attar@amd.com>

Corrects the function pointer typedef AML_PARSE_FUNCTION,
otherwise some compiler like VS2019 gives error.

Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/Dy=
namicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
index 8e584d4930..d3a51a94c7 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
@@ -100,8 +100,7 @@ AmlParseStream (
 **/
 typedef
 EFI_STATUS
-EFIAPI
-(*AML_PARSE_FUNCTION) (
+(EFIAPI *AML_PARSE_FUNCTION)(
   IN      CONST AML_NODE_HEADER   *Node,
   IN            AML_PARSE_FORMAT  ExpectedFormat,
   IN  OUT       AML_STREAM        *FStream,
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#112816) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------4PVkoQh2ufic94UdKwKtaRNc--