From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 26 Sep 2019 05:45:42 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1345BA44AD2; Thu, 26 Sep 2019 12:45:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-49.rdu2.redhat.com [10.10.120.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0BECAF6F8; Thu, 26 Sep 2019 12:45:40 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls From: "Laszlo Ersek" To: Chao Zhang , Jian Wang , Jiewen Yao Cc: edk2-devel-groups-io Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-27-lersek@redhat.com> Message-ID: <70253a73-a5ef-501f-c08b-207bb9c1200d@redhat.com> Date: Thu, 26 Sep 2019 14:45:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-27-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 26 Sep 2019 12:45:42 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Chao, Jian, Jiewen, can you please review this patch? Thanks, Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > Unlike the InstallMultipleProtocolInterfaces() boot service, which takes > an (EFI_HANDLE*) as first parameter, the > UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as > first parameter. > > These are actual bugs. They must have remained hidden until now because > they are all in Unload() functions, which are probably exercised > infrequently. Fix the UninstallMultipleProtocolInterfaces() calls. > > Cc: Chao Zhang > Cc: Jian Wang > Cc: Jiewen Yao > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c | 2 +- > SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c | 2 +- > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDriver.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c > index 54155a338100..9052eced757d 100644 > --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c > +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c > @@ -443,7 +443,7 @@ Tcg2ConfigDriverUnload ( > ASSERT (PrivateData->Signature == TCG2_CONFIG_PRIVATE_DATA_SIGNATURE); > > gBS->UninstallMultipleProtocolInterfaces ( > - &ImageHandle, > + ImageHandle, > &gEfiCallerIdGuid, > PrivateData, > NULL > diff --git a/SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c b/SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c > index 341879e4c4ba..fb06624fdb8f 100644 > --- a/SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c > +++ b/SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDriver.c > @@ -138,7 +138,7 @@ TcgConfigDriverUnload ( > ASSERT (PrivateData->Signature == TCG_CONFIG_PRIVATE_DATA_SIGNATURE); > > gBS->UninstallMultipleProtocolInterfaces ( > - &ImageHandle, > + ImageHandle, > &gEfiCallerIdGuid, > PrivateData, > NULL > diff --git a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDriver.c b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDriver.c > index 798ef9cfbc01..6c0294151e6c 100644 > --- a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDriver.c > +++ b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDriver.c > @@ -115,7 +115,7 @@ SecureBootConfigDriverUnload ( > ASSERT (PrivateData->Signature == SECUREBOOT_CONFIG_PRIVATE_DATA_SIGNATURE); > > gBS->UninstallMultipleProtocolInterfaces ( > - &ImageHandle, > + ImageHandle, > &gEfiCallerIdGuid, > PrivateData, > NULL >