From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by mx.groups.io with SMTP id smtpd.web10.11579.1675333762037598303
 for <devel@edk2.groups.io>;
 Thu, 02 Feb 2023 02:29:22 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=kdV4JaOA;
 spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout01.posteo.de (Postfix) with ESMTPS id 496EB2402EE
	for <devel@edk2.groups.io>; Thu,  2 Feb 2023 11:29:20 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1675333760; bh=qrxafDZOzwN9C9ckpFaENULdsNzknLtK8Ss8msVLKIs=;
	h=From:Subject:Date:Cc:To:From;
	b=kdV4JaOA3jIQ7uETIObfBG3RbUg0vIxqkQ4MNrLTXffjLh8A0GG2zxVsW0rILbCtQ
	 t7oSDBkNHEKEwES316irrrWhAkJYzRtNDKEgjwUOV0E9hSNZh3A8aQvLQhUSAbH+hf
	 HUpPq9VIlPmgVzuau/wWrE71vbtAoW1dJrqEmDA82eEExWRHwEaWSxFCkCfoerR5J3
	 +KJ0f8KCYiRyKHu4G/m3URtqH7XCxkA8okOk8QDrPgyNZoI4NSeYjlQ5IvekgFviqB
	 oL+E5LU74VTGkRuQd7abZ/MYdWFPBt1lTC+sB3NBsVxvkk5SXF4fXbJwMePA4uKF0H
	 47ceQ75thnkIA==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4P6w4v0YzNz6tmH;
	Thu,  2 Feb 2023 11:29:19 +0100 (CET)
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
Mime-Version: 1.0 (1.0)
Subject: Re: [edk2-platforms][PATCH v4 12/12] Ext4Pkg: Corrects memory leak in Ext4ReadSlowSymlink
Date: Thu,  2 Feb 2023 10:29:18 +0000
Message-Id: <7041E88E-AD24-4FB5-8773-D4B1E1EBE3FB@posteo.de>
References: <20230202102133.51606-13-savvamtr@gmail.com>
Cc: devel@edk2.groups.io, Pedro Falcato <pedro.falcato@gmail.com>,
 Vitaly Cheptsov <vit9696@protonmail.com>
In-Reply-To: <20230202102133.51606-13-savvamtr@gmail.com>
To: Savva Mitrofanov <savvamtr@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Marvin H=C3=A4user <mhaeuser@posteo.de>

> On 2. Feb 2023, at 11:21, Savva Mitrofanov <savvamtr@gmail.com> wrote:
>=20
> =EF=BB=BFWe need to free SymlinkTmp before exiting if SymlinkSizeTmp !=3D R=
eadSize
> condition is true
>=20
> Reported-by: Marvin H=C3=A4user <mhaeuser@posteo.de>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Vitaly Cheptsov <vit9696@protonmail.com>
> Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support")
> Signed-off-by: Savva Mitrofanov <savvamtr@gmail.com>
> Reviewed-by: Marvin H=C3=A4user <mhaeuser@posteo.de>
> ---
> Features/Ext4Pkg/Ext4Dxe/Symlink.c | 1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dxe=
/Symlink.c
> index 8b1511a38b55..1189a99ded2b 100644
> --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> @@ -160,6 +160,7 @@ Ext4ReadSlowSymlink (
>       DEBUG_FS,
>       "[ext4] Error! The size of the read block doesn't match the value fr=
om the inode!\n"
>       ));
> +    FreePool (SymlinkTmp);
>     return EFI_VOLUME_CORRUPTED;
>   }
>=20
> --=20
> 2.39.1
>=20