From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7DCEF7803CD for ; Tue, 16 Apr 2024 05:03:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NYVF5ESdCxLlcP/p5DG8paWX9HtZFawzhmm1euhPdjo=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1713243788; v=1; b=wPJZTsjmlluWRig6FWZCTE0esqyWZ/dY7gRwjaR9l4ZhMS8uAmgmp1m17Exj5otQRidrRPKT Jbx6o6pzDUjLffqa1mLbvMM5/PE4VcjWFQP8HLl7nw1pZb9mDTsZ/IZw0mcgIKXGddp30CvHYnV h0zF57TgCJo26jUIEVLdu34VIGgj0gxsceFlPQwXUY/bbn4HSvqOBfyLuXtYKpjKfb13ldmPdQ+ 5WuyIdpXE0G8pCarUkWK23x130g8ORVTmzPI68+4uZSEi/E2fGep4dSQQP44nUF0uDjVmXt3IT6 D1KK5A0u1zSX+9Esn4wD01Dp6utNrGwek1kL2VgtOyoDA== X-Received: by 127.0.0.2 with SMTP id ts0AYY7687511xPMmVID57ht; Mon, 15 Apr 2024 22:03:08 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web10.12880.1713243787617544347 for ; Mon, 15 Apr 2024 22:03:07 -0700 X-CSE-ConnectionGUID: QXTWURPbQ9+W69XolwUUuA== X-CSE-MsgGUID: HYoTTfTHQgSvEZi+OJSinw== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="11607372" X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="11607372" X-Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 22:03:07 -0700 X-CSE-ConnectionGUID: 357xjcZrQQGMhJvcXGA8ig== X-CSE-MsgGUID: AwCIt8gKTIKkUuN1DrLmrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="22223838" X-Received: from cindykux-mobl.gar.corp.intel.com ([10.225.33.115]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 22:03:05 -0700 From: "Cindy Kuo" To: devel@edk2.groups.io Cc: Cindy Kuo , Jiewen Yao , Rahul Kumar , Dandan Bi , Ming Tan , Arthur Chen , Xiao X Chen , Tina Chen Subject: [edk2-devel] [PATCH v5 1/2] SecurityPkg/OpalPasswordDxe: Change callback action to meet UEFI spec Date: Tue, 16 Apr 2024 13:02:36 +0800 Message-ID: <704312e2668c25463db9eb7c49d65a6273043b4c.1713241069.git.cindyx.kuo@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 22:03:07 -0700 Resent-From: cindyx.kuo@intel.com Reply-To: devel@edk2.groups.io,cindyx.kuo@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Za78h5G02U3rgBiDkTgOJu5jx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=wPJZTsjm; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4735 Should not call HiiGetBrowserData() and HiiSetBrowserData() in ACTION_FORM_OPEN callback function. Those APIs are called within OpalHiiSetBrowserData/OpalHiiGetBrowserData which have been used by OpalHii.c. Change callback action from FORM_OPEN to RETRIEVE to meet UEFI spec. Cc: Jiewen Yao Cc: Rahul Kumar Cc: Dandan Bi Cc: Ming Tan Cc: Arthur Chen Cc: Xiao X Chen Cc: Tina Chen Signed-off-by: CindyX Kuo Reviewed-by: Dandan Bi Reviewed-by: Tina Chen --- SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c index 8035f44ebe..56ada1a9f3 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c @@ -632,7 +632,7 @@ DriverCallback ( HiiKey.Raw = QuestionId; HiiKeyId = (UINT8)HiiKey.KeyBits.Id; - if (Action == EFI_BROWSER_ACTION_FORM_OPEN) { + if (Action == EFI_BROWSER_ACTION_RETRIEVE) { switch (HiiKeyId) { case HII_KEY_ID_VAR_SUPPORTED_DISKS: DEBUG ((DEBUG_INFO, "HII_KEY_ID_VAR_SUPPORTED_DISKS\n")); -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117847): https://edk2.groups.io/g/devel/message/117847 Mute This Topic: https://groups.io/mt/105551558/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-