From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web11.87.1594829508460762320
 for <devel@edk2.groups.io>;
 Wed, 15 Jul 2020 09:11:48 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZS1pAAqG;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1594829507;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IBVKZ995P54MV1Qw9KORkrO5l6YpNLnQ0TmSIS07hb4=;
	b=ZS1pAAqGvykKorw0cakAW+dHcornHEk9EUq+Fe9IrB7x0vFV+nVN1Q55NXSEmlGIXAEKLC
	nWWYOoaQ/DlnUP0d/5u6oNineSdy4K7N14hCbIZby9+ej0bTx4jGs1tSdwMrt9ipuOIfWp
	JEbUBDAOqn5YgaEajT8FM2ov+Ped1v8=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-192-K_ELrAhUO8GS-lgYsjEjDQ-1; Wed, 15 Jul 2020 12:11:42 -0400
X-MC-Unique: K_ELrAhUO8GS-lgYsjEjDQ-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 275031800D42;
	Wed, 15 Jul 2020 16:11:41 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-3.ams2.redhat.com [10.36.114.3])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 436A719D61;
	Wed, 15 Jul 2020 16:11:39 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v10 16/46] OvmfPkg/VmgExitLib: Add support for MSR_PROT NAE events
To: devel@edk2.groups.io, thomas.lendacky@amd.com
Cc: Brijesh Singh <brijesh.singh@amd.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>, Eric Dong <eric.dong@intel.com>,
 Jordan Justen <jordan.l.justen@intel.com>, Liming Gao
 <liming.gao@intel.com>, Michael D Kinney <michael.d.kinney@intel.com>,
 Ray Ni <ray.ni@intel.com>
References: <cover.1594736896.git.thomas.lendacky@amd.com>
 <3daa8d5e420de73e5d63a71d79910523abcf0f5b.1594736896.git.thomas.lendacky@amd.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <704e3a28-8d76-a946-cc13-a3b8623ce1f6@redhat.com>
Date: Wed, 15 Jul 2020 18:11:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <3daa8d5e420de73e5d63a71d79910523abcf0f5b.1594736896.git.thomas.lendacky@amd.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 07/14/20 16:27, Lendacky, Thomas wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> 
> Under SEV-ES, a MSR_PROT intercept generates a #VC exception. VMGEXIT must
> be used to allow the hypervisor to handle this intercept.
> 
> Add support to construct the required GHCB values to support an MSR_PROT
> NAE event. Parse the instruction that generated the #VC exception to
> determine whether it is RDMSR or WRMSR, setting the required register
> register values in the GHCB and creating the proper SW_EXIT_INFO1 value in
> the GHCB.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)

Thanks for the comment updates, my ACK stands.
Laszlo