From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web09.9868.1609948094356763676
 for <devel@edk2.groups.io>;
 Wed, 06 Jan 2021 07:48:14 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Jd8/umoT;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1609948093;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GlN5zBhkC1J3S4l5/rb3DNR6B0rp27p94Z3DH0n61RI=;
	b=Jd8/umoTOQQJBmRmmqP7BmuuJOBErmL64gT5MXzlU+gWepNM31gXlDP6/joh5kKwf+0+lP
	DtoNo05rePvYEPaP912955fuSZPzfnOkbiR7O9q7jZL7MpeEQMYOxTed5HWltLdfEsOByS
	gnEiA8XYKgWdxrcHzVEGpwpDwLYpbY4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-212-eB3MJIH7MRGFOjtvvriZMg-1; Wed, 06 Jan 2021 10:48:11 -0500
X-MC-Unique: eB3MJIH7MRGFOjtvvriZMg-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7993D800D62;
	Wed,  6 Jan 2021 15:48:10 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-198.ams2.redhat.com [10.36.113.198])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 1D5D510023AD;
	Wed,  6 Jan 2021 15:48:08 +0000 (UTC)
Subject: Re: [PATCH v2 16/16] UefiCpuPkg: SmmCpuExceptionHandlerLib: Added StandaloneMm module support
To: Kun Qin <kun.q@outlook.com>, devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
 Rahul Kumar <rahul1.kumar@intel.com>
References: <20210105185935.3769-1-kun.q@outlook.com>
 <MWHPR06MB3102ADDADA287A79DFA67749F3D10@MWHPR06MB3102.namprd06.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <706ff206-9f3a-30c1-25b4-e417deaddabd@redhat.com>
Date: Wed, 6 Jan 2021 16:48:08 +0100
MIME-Version: 1.0
In-Reply-To: <MWHPR06MB3102ADDADA287A79DFA67749F3D10@MWHPR06MB3102.namprd06.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/05/21 19:59, Kun Qin wrote:
> This change of SmmCpuExceptionHandlerLib adds support for StandaloneMm
> components to allow x64 StandaloneMm environment setting up exception
> handlers.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> 
> Signed-off-by: Kun Qin <kun.q@outlook.com>
> ---
> 
> Notes:
>     v2:
>     - No review, no change.
> 
>  UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf
> index 4cdb11c04ea0..ea5b10b5c8e4 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf
> @@ -13,7 +13,7 @@ [Defines]
>    FILE_GUID                      = 8D2C439B-3981-42ff-9CE5-1B50ECA502D6
>    MODULE_TYPE                    = DXE_SMM_DRIVER
>    VERSION_STRING                 = 1.1
> -  LIBRARY_CLASS                  = CpuExceptionHandlerLib|DXE_SMM_DRIVER
> +  LIBRARY_CLASS                  = CpuExceptionHandlerLib|DXE_SMM_DRIVER MM_STANDALONE MM_CORE_STANDALONE
>  
>  #
>  # The following information is for reference only and not required by the build tools.
> 

Looks innocent enough to me.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>