From: "Marvin Häuser" <mhaeuser@posteo.de>
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>,
Hao A Wu <hao.a.wu@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Guomin Jiang <guomin.jiang@intel.com>,
Vitaly Cheptsov <vit9696@protonmail.com>
Subject: [PATCH 1/1] MdeModulePkg/CapsuleApp: Add missing EFIAPI specifier
Date: Sun, 15 Aug 2021 20:11:55 +0000 [thread overview]
Message-ID: <7070ec1badae7d2da9c45e6e0c3674273b4697fe.1629057804.git.mhaeuser@posteo.de> (raw)
The function CompareFileNameInAlphabet() is passed by pointer to a
generic sorting function. Said pointer declares a function type with
the EFIAPI calling convention. As CompareFileNameInAlphabet() lacks
said specifier, this causes build issues with toolchains that do not
use the EFIAPI calling convention by default, such as CLANG38.
Add the missing specifier to resolve the issue.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>
Signed-off-by: Marvin Häuser <mhaeuser@posteo.de>
---
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
index 5725e2f6dd5b..30a4a984f318 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
@@ -622,6 +622,7 @@ SplitFileNameExtension (
**/
INTN
+EFIAPI
CompareFileNameInAlphabet (
IN VOID *Left,
IN VOID *Right
--
2.31.1
reply other threads:[~2021-08-15 20:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7070ec1badae7d2da9c45e6e0c3674273b4697fe.1629057804.git.mhaeuser@posteo.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox