public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] MdeModulePkg/CapsuleApp: Add missing EFIAPI specifier
@ 2021-08-15 20:11 Marvin Häuser
  0 siblings, 0 replies; only message in thread
From: Marvin Häuser @ 2021-08-15 20:11 UTC (permalink / raw)
  To: devel; +Cc: Jian J Wang, Hao A Wu, Liming Gao, Guomin Jiang, Vitaly Cheptsov

The function CompareFileNameInAlphabet() is passed by pointer to a
generic sorting function. Said pointer declares a function type with
the EFIAPI calling convention. As CompareFileNameInAlphabet() lacks
said specifier, this causes build issues with toolchains that do not
use the EFIAPI calling convention by default, such as CLANG38.

Add the missing specifier to resolve the issue.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>
Signed-off-by: Marvin Häuser <mhaeuser@posteo.de>
---
 MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
index 5725e2f6dd5b..30a4a984f318 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
@@ -622,6 +622,7 @@ SplitFileNameExtension (
 
 **/
 INTN
+EFIAPI
 CompareFileNameInAlphabet (
   IN VOID                         *Left,
   IN VOID                         *Right
-- 
2.31.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-15 20:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-15 20:11 [PATCH 1/1] MdeModulePkg/CapsuleApp: Add missing EFIAPI specifier Marvin Häuser

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox