public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-test 1/1] uefi-sct/SctPkg: uefi-sct: QueryVariableInfo(EFI_VARIABLE_NON_VOLATILE)
@ 2021-06-30 14:50 Heinrich Schuchardt
  2021-08-09 10:44 ` [edk2-devel] " G Edhaya Chandran
  0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-06-30 14:50 UTC (permalink / raw)
  To: EDK II Development
  Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen,
	Samer El-Haj-Mahmoud, Masami Hiramatsu, Heinrich Schuchardt

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3469

The Self Certification Test (SCT) II Case Specification, 2017 requires
in 5.2.1.4.5. that QueryVariableInfo() shall fail for

    attributes = EFI_VARIABLE_NON_VOLATILE.

Add EFI_VARIABLE_NON_VOLATILE to tested values in function
QueryVariableInfoConfTestSub5().

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 .../BlackBoxTest/VariableServicesBBTestConformance.c             | 1 +
 1 file changed, 1 insertion(+)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestConformance.c
index e2182c5cca7b..731a3cadeac2 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestConformance.c
@@ -3399,6 +3399,7 @@ QueryVariableInfoConfTestSub5 (
 {
   EFI_STATUS            Status;
   UINT32                InvalidAttributes[] = {
+                          EFI_VARIABLE_NON_VOLATILE,
                           EFI_VARIABLE_RUNTIME_ACCESS,
                           EFI_VARIABLE_NON_VOLATILE|EFI_VARIABLE_RUNTIME_ACCESS,
                           0
--
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: uefi-sct: QueryVariableInfo(EFI_VARIABLE_NON_VOLATILE)
  2021-06-30 14:50 [PATCH edk2-test 1/1] uefi-sct/SctPkg: uefi-sct: QueryVariableInfo(EFI_VARIABLE_NON_VOLATILE) Heinrich Schuchardt
@ 2021-08-09 10:44 ` G Edhaya Chandran
  2021-08-09 10:51   ` G Edhaya Chandran
  0 siblings, 1 reply; 3+ messages in thread
From: G Edhaya Chandran @ 2021-08-09 10:44 UTC (permalink / raw)
  To: Heinrich Schuchardt, devel

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com>

The bugzilla ticket is : 3469 – uefi-sct: QueryVariableInfo(attributes = EFI_VARIABLE_NON_VOLATILE) (tianocore.org) ( https://bugzilla.tianocore.org/show_bug.cgi?id=3469 )

[-- Attachment #2: Type: text/html, Size: 273 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: uefi-sct: QueryVariableInfo(EFI_VARIABLE_NON_VOLATILE)
  2021-08-09 10:44 ` [edk2-devel] " G Edhaya Chandran
@ 2021-08-09 10:51   ` G Edhaya Chandran
  0 siblings, 0 replies; 3+ messages in thread
From: G Edhaya Chandran @ 2021-08-09 10:51 UTC (permalink / raw)
  To: G Edhaya Chandran, devel

[-- Attachment #1: Type: text/plain, Size: 129 bytes --]

The solution is upstreamed by commit-id: https://github.com/tianocore/edk2-test/commit/814b2af535d977b3967d65de77e42ab18a4f4db4

[-- Attachment #2: Type: text/html, Size: 266 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-09 10:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-30 14:50 [PATCH edk2-test 1/1] uefi-sct/SctPkg: uefi-sct: QueryVariableInfo(EFI_VARIABLE_NON_VOLATILE) Heinrich Schuchardt
2021-08-09 10:44 ` [edk2-devel] " G Edhaya Chandran
2021-08-09 10:51   ` G Edhaya Chandran

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox