From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.75]) by mx.groups.io with SMTP id smtpd.web10.3845.1588797454562604238 for ; Wed, 06 May 2020 13:37:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=M2RqGZIQ; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.236.75, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MzjCAn5lKyZKrw3bZYeg/IwIaSSWT3c+pTrW3ddprqfDe4RYNfoFlYv/0i+ReTboM2WecvQ5AQ8Y+MLa8oes5Ozky4sLere+8vhesfs/JSG9LlvkEYNGcsYDdo7sgWa+NvscRb+pU2JhNyJDsVIiJQYa3nWJVKEBkTIF7163ifRC6dSKPxizXH1pX7N1XRLbywyt98okLjt4hft6rmsEJGhRRD8h8ZaS4VfsfhMrxNGmzQ0qtqFqkCwvatFUXlvL9PtKyZhBaiCGxJ0+gU+c7cKNNEs0WyGsgWJGRwUWpblsTVFiusrh6FtHimTnomOmoOqH6cYN8BSAwKx5idOEQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqMtjW9jbX6tMiTdBodMNdHLXo1ZXrkLRWhgw2y6mWw=; b=J3WYLAUkA/ragG8RTwJMKFbW4IYWXyglTPIfEl6qbLYxhxOEOW94JPP2MwpNlRXrv/iiuFrzb+DEOqh39HLV0o+o/4MzeRd/Y8+ZAcaK8FS2d4yopwXpNAwwXRvx4U9tawud/FypgdAW1nqh5tUe+Hi9l9s0a4CMNPfjENmdZoZ8CfP8SwgmooryFt6vAt5fKbs+wMZMaaNdABx8dpJSHzR7AwsybXHL9o6har2s2UgryqQUJsKajM/Njga74XN7Sdb3OtMKuzq1C8yvgKLQCJeRU6zBWwhcJOp8HWb+eojSe3qHyHPCpsMd31ffmwBLrY2X75PbczwHaPH15u4l9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqMtjW9jbX6tMiTdBodMNdHLXo1ZXrkLRWhgw2y6mWw=; b=M2RqGZIQ2KY3hhpbG9lJF6VU9fPwiu2ipUBnmyKHgSFgu1BynD3W0kngYIAPQzBdxcVOdbPG0DsLwKb3+T1098UDsYHzQjOkiFrybfq9jHf6oKVLDct5J0uMeEHJ976oxAnBQq82z/XpmszoFfBLrKnRfrmyVx0hvs3mXTZPm0U= Authentication-Results: apple.com; dkim=none (message not signed) header.d=none;apple.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR12MB1420.namprd12.prod.outlook.com (2603:10b6:3:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 6 May 2020 20:37:32 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::4ce1:9947:9681:c8b1]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::4ce1:9947:9681:c8b1%10]) with mapi id 15.20.2958.030; Wed, 6 May 2020 20:37:32 +0000 Subject: Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/CpuExceptionHandler: Make XCODE5 changes toolchain specific To: devel@edk2.groups.io, lersek@redhat.com Cc: Jordan Justen , Ard Biesheuvel , Liming Gao , Eric Dong , Ray Ni , Anthony Perard , Julien Grall , Brijesh Singh , Andrew Fish References: <5fad89a0bdea4743b13815078e68bcf122c4f63b.1588782781.git.thomas.lendacky@amd.com> <5d973f64-22fa-6f83-7b1b-cb97a7efe400@redhat.com> From: "Lendacky, Thomas" Message-ID: <7086eef3-cf00-6254-65b4-bf982b0f4f9e@amd.com> Date: Wed, 6 May 2020 15:37:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 In-Reply-To: <5d973f64-22fa-6f83-7b1b-cb97a7efe400@redhat.com> X-ClientProxiedBy: SN1PR12CA0093.namprd12.prod.outlook.com (2603:10b6:802:21::28) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from office-linux.texastahm.com (67.79.209.213) by SN1PR12CA0093.namprd12.prod.outlook.com (2603:10b6:802:21::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Wed, 6 May 2020 20:37:31 +0000 X-Originating-IP: [67.79.209.213] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d599120e-7e65-4dcd-85fc-08d7f1fd4d7f X-MS-TrafficTypeDiagnostic: DM5PR12MB1420:|DM5PR12MB1420: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1K3SkxPL/nH+bOFHLTmFNWajxnuNuv2J2+96CcxLYgUNvQm7ro0JrlSVTGxJnQSDRVS723zp4C2qduq66ekRiEocGgGbkAtYkMrdFLDZMObZCHEzDkJN0apNyuPS2sJqC7B2buzRtDmguyZ41OOD9bCfuYM2mLCR31PZX35B0hVgoMg91tOTe7C8i+A+8TFTK5AzvGQNejSxzb+1YjrGv7ISPZ3Z8DTP+gnESF+Dpkfk5JC/QlDoA8qlyJroi8yun2sgVrOr+0RHz8zXck5xuGxklF9cb4KJzfZBN0WL+0G26HqWB9yEqaPIib0F1fNdHf8WFci/KzZuJwa4wTICTUmr46RbBMHpKzfSdFeBZYrMvObovYkcfadqHLwWw0WtYuD+wEtQiI43q1KZdWhiYhxTCoFTTGYtj0+dfc1M5LHWXVqAgkzLVSyjCaaI7ynnh31ro5TqwuhxRHPtym3dnOA8n7LTDBlRm2LOX5e+u3aUadkui0rFDPBb9WZMH/UMhC5PFvGrM0i7vQzZYHH0EnVpyx/iYwjRPa3RGJtzv34+baJsS72cz7SbA+xpHtWidbwF1KPLSDkJWm/mMUMDDzxczfnisK54rP7IL73Gr2NcNE/0G2I51q9rAcXk3BxDKUtbmHFwAAInN1RHCzK6OA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(39860400002)(376002)(396003)(366004)(33430700001)(66556008)(6486002)(66476007)(52116002)(66946007)(7416002)(31696002)(6506007)(186003)(31686004)(26005)(86362001)(16526019)(8676002)(53546011)(478600001)(30864003)(5660300002)(45080400002)(2616005)(19627235002)(54906003)(33440700001)(4326008)(966005)(6512007)(316002)(36756003)(2906002)(956004)(8936002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Bku29VrUkMnJqgpNRrhjOFjtXOUCmxxsWgRRPpiBKAV0+NNf4ZHNFcZXjTb7cY3d5zSqmQWpF7vofLsffRbsKVCiCxL61DPA1RSIdkAXV7398ekXuj+TgAY1/aYa6Kou8Jk5fff6LXxH+pY+alhZWrBXjSXySEXgi8pIUs73fTLZIs9a3ieeJvLnd2a9Ul+xIsoYQInFaODBgEa8x1dXDt5YWs0R2abLLr3mCLxLf/gTdNQmMRKQl0V2wB8I5q3CqIELw1s63WOqWryDSFQYRApOkD9sGQNN40jT2SaStZCfNluovfnXZNkjI4ocfTbrC2hTXM7Es6qncvC/A9WwuZrFmFIK23jIudFLpuGeQ6FxhHEqJz7bTSaAz1Ocy1QDtSTLwPLcd0yICt2JKTgRJm0vChFgIxLk+sMDVWcJG7w6Zm2Hx0vnJhhW37ljh1ICMa5GI9+4k7pKEklM2MoYM7k/GQHdvuT3b4jYw2gU9GYyp9HX5rt8wBatS5SCjTI1S4vWEL1wMVuKxGgIjNVs+olAAkYTQSZTCj16iy1Kt5WVX2F0S3PkkN8BBXo/SfxeO/N/KUg6476Cu059wiCDgL1B4QiS/TbDut/EgGYmdNAqaCdehrmf79ir1EENzx9cwNYTxohUrb/o0eDySzqSSHR1wKD+Z5eEo//wRtFRb5X6okdKADC9jPPiSJW1lTLEdg5xonZFGHXnXuDHZS3mnJ3aCx+a/a/qo4gyOEbe17cu0+0UKUyICCf1DyTyPVB8SOAY+uVTGAirVulrbcZ7vB6Ojsgz5z2uf+3WskgDEhQ= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d599120e-7e65-4dcd-85fc-08d7f1fd4d7f X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 20:37:32.7856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z6HlF9ZzN3FwKezsDogX9/DUysSv0qdfmQvJHoeK5XV7xDkq8pRGIc4LzcjImU9Ra2wJFzevRlY0t620j++4BQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1420 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/6/20 2:01 PM, Laszlo Ersek via groups.io wrote: > On 05/06/20 18:33, Tom Lendacky wrote: >> BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2340&data=02%7C01%7Cthomas.lendacky%40amd.com%7C3c47ab80a1554f27afd608d7f1eff6e8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637243885258646451&sdata=Xh7E1EB%2B1oOCtc2jgtJ8lsjgcwxgswIbgpL4%2BUwpoOw%3D&reserved=0 >> >> Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass >> XCODE5 tool chain") introduced binary patching into the exception handling >> support. CPU exception handling is allowed during SEC and this results in >> binary patching of flash, which should not be done. >> >> Separate the changes from commit 2db0ccc2d7fe into an XCODE5 toolchain >> specific file, Xcode5ExceptionHandlerAsm.nasm, and create a new SEC INF >> file for the XCODE5 version of CpuExceptionHandlerLib. >> >> Since binary patching is allowed when running outside of flash, switch >> the Dxe, Pei and Smm versions of the CpuExceptionHandlerLib over to use >> the Xcode5ExceptionHandlerAsm.nasm file to retain current functionality. >> >> Cc: Eric Dong >> Cc: Ray Ni >> Cc: Laszlo Ersek >> Cc: Liming Gao >> Signed-off-by: Tom Lendacky >> --- >> UefiCpuPkg/UefiCpuPkg.dsc | 5 + >> .../DxeCpuExceptionHandlerLib.inf | 2 +- >> .../PeiCpuExceptionHandlerLib.inf | 2 +- >> .../SmmCpuExceptionHandlerLib.inf | 2 +- >> .../Xcode5SecPeiCpuExceptionHandlerLib.inf | 54 +++ >> .../X64/Xcode5ExceptionHandlerAsm.nasm | 396 ++++++++++++++++++ >> .../Xcode5SecPeiCpuExceptionHandlerLib.uni | 17 + >> 7 files changed, 475 insertions(+), 3 deletions(-) >> create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf >> create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionHandlerAsm.nasm >> create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.uni >> >> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc >> index d28cb5cccb52..264e5a787bce 100644 >> --- a/UefiCpuPkg/UefiCpuPkg.dsc >> +++ b/UefiCpuPkg/UefiCpuPkg.dsc >> @@ -59,7 +59,11 @@ [LibraryClasses] >> >> [LibraryClasses.common.SEC] >> PlatformSecLib|UefiCpuPkg/Library/PlatformSecLibNull/PlatformSecLibNull.inf >> +!if $(TOOL_CHAIN_TAG) == "XCODE5" >> + CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf >> +!else >> CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf >> +!endif >> HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf >> PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf >> MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf >> @@ -126,6 +130,7 @@ [Components.IA32, Components.X64] >> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf > > (1) I think this lib instance ("SecPeiCpuExceptionHandlerLib.inf") may > not build with XCODE5 at the end of the series, even in stand-alone > mode. Thus I think it should be conditionalized with > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > ... > !endif > > When using XCODE5, we should only build > "Xcode5SecPeiCpuExceptionHandlerLib.inf"; otherwise, we should build > *both* "SecPeiCpuExceptionHandlerLib.inf" and > ".inf". > This is the area that was resulting in the error when I used the pull request to run the integration tests. I was using an if/else originally, I'll try just the if != XCODE5 around SecPeiCpuExceptionHandlerLib.inf and see if that goes through. If not, Brett Barkelew responded with a suggestion to add the Xcode5SecPeiCpuExceptionHandlerLib.inf to the ignore list in the CI yaml file. For the next version, under [Components], it will look like: @@ -123,9 +127,12 @@ [Components.IA32, Components.X64] UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf +!if $(TOOL_CHAIN_TAG) != "XCODE5" UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf +!endif UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf + UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf >> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf >> UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf >> + UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf >> UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf >> UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf >> UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf >> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf >> index e41383573043..61e2ec30b089 100644 >> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf >> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf >> @@ -28,7 +28,7 @@ [Sources.Ia32] >> Ia32/ArchInterruptDefs.h >> >> [Sources.X64] >> - X64/ExceptionHandlerAsm.nasm >> + X64/Xcode5ExceptionHandlerAsm.nasm >> X64/ArchExceptionHandler.c >> X64/ArchInterruptDefs.h >> >> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf >> index f31423ac0f91..093374944df6 100644 >> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf >> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf >> @@ -28,7 +28,7 @@ [Sources.Ia32] >> Ia32/ArchInterruptDefs.h >> >> [Sources.X64] >> - X64/ExceptionHandlerAsm.nasm >> + X64/Xcode5ExceptionHandlerAsm.nasm >> X64/ArchExceptionHandler.c >> X64/ArchInterruptDefs.h >> >> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf >> index 66c7f59e3c91..2ffbbccc302f 100644 >> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf >> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf >> @@ -28,7 +28,7 @@ [Sources.Ia32] >> Ia32/ArchInterruptDefs.h >> >> [Sources.X64] >> - X64/ExceptionHandlerAsm.nasm >> + X64/Xcode5ExceptionHandlerAsm.nasm >> X64/ArchExceptionHandler.c >> X64/ArchInterruptDefs.h >> >> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf >> new file mode 100644 >> index 000000000000..3ed1378d6fa6 >> --- /dev/null >> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf >> @@ -0,0 +1,54 @@ >> +## @file >> +# CPU Exception Handler library instance for SEC/PEI modules. >> +# >> +# Copyright (c) 2012 - 2018, Intel Corporation. All rights reserved.
>> +# SPDX-License-Identifier: BSD-2-Clause-Patent > > (2) This is a customized copy of "SecPeiCpuExceptionHandlerLib.inf"; I > think you should prepend your (C) notice. Ok. > >> +# >> +# This is the XCODE5 variant of the SEC/PEI CpuExceptionHandlerLib. This >> +# variant performs binary patching to fix up addresses that allow the >> +# XCODE5 toolchain to be used. >> +# >> +## >> + >> +[Defines] >> + INF_VERSION = 0x00010005 >> + BASE_NAME = Xcode5SecPeiCpuExceptionHandlerLib >> + MODULE_UNI_FILE = Xcode5SecPeiCpuExceptionHandlerLib.uni >> + FILE_GUID = 49C481AF-1621-42F3-8FA1-27C64143E304 >> + MODULE_TYPE = PEIM >> + VERSION_STRING = 1.1 >> + LIBRARY_CLASS = CpuExceptionHandlerLib|SEC PEI_CORE PEIM >> + <... SNIP ...> >> +global ASM_PFX(AsmVectorNumFixup) >> +ASM_PFX(AsmVectorNumFixup): >> + mov rax, rdx >> + mov [rcx + (@VectorNum - HookAfterStubHeaderBegin)], al >> + ret >> + >> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.uni b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.uni >> new file mode 100644 >> index 000000000000..be69992cef09 >> --- /dev/null >> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.uni >> @@ -0,0 +1,17 @@ >> +// /** @file >> +// XCODE5 CPU Exception Handler library instance for SEC/PEI modules. >> +// >> +// CPU Exception Handler library instance for SEC/PEI modules when built >> +// using the XCODE5 toolchain. >> +// >> +// Copyright (c) 2012 - 2014, Intel Corporation. All rights reserved.
>> +// >> +// SPDX-License-Identifier: BSD-2-Clause-Patent >> +// >> +// **/ >> + >> + >> +#string STR_MODULE_ABSTRACT #language en-US "CPU Exception Handler library instance for SEC/PEI modules with the XCODE5 toolchain." >> + >> +#string STR_MODULE_DESCRIPTION #language en-US "CPU Exception Handler library instance for SEC/PEI modules with the XCODE5 toolchain." >> + >> > > (3) This is a brand new file; I think you should prepend your (C) notice. Ok. > > Meta-hint: with patches like this, it sometimes makes sense to format > the series for posting with "--find-copies-harder". Ah, I'll do that on the next version. Thanks, Tom > > With (1) through (3) updated: > > Reviewed-by: Laszlo Ersek > > Thanks, > Laszlo > > > >