* Re: [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build
2019-10-15 11:07 [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build Ard Biesheuvel
@ 2019-10-15 12:21 ` Sami Mujawar
2019-10-15 12:51 ` Laszlo Ersek
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Sami Mujawar @ 2019-10-15 12:21 UTC (permalink / raw)
To: Ard Biesheuvel, devel@edk2.groups.io
Cc: lersek@redhat.com, leif.lindholm@linaro.org
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Sent: 15 October 2019 12:08 PM
To: devel@edk2.groups.io
Cc: lersek@redhat.com; Sami Mujawar <Sami.Mujawar@arm.com>; leif.lindholm@linaro.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build
DynamicTablesPkg can be built for ARM as well as for AARCH64, but on the former, doing so will result in a build failure due to the lack of 64-bit division helpers provided by the ArmPkg intrinsics library.
So add the missing reference, for both ARM and AARCH64 (which may start relying on intrinsics due to future changes)
Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2269
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc
index ef958077ed48..19beaaf370f8 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.dsc
+++ b/DynamicTablesPkg/DynamicTablesPkg.dsc
@@ -32,6 +32,7 @@ [LibraryClasses]
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
[LibraryClasses.ARM, LibraryClasses.AARCH64]
+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
[Components.common]
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build
2019-10-15 11:07 [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build Ard Biesheuvel
2019-10-15 12:21 ` Sami Mujawar
@ 2019-10-15 12:51 ` Laszlo Ersek
2019-10-16 11:51 ` [edk2-devel] " Philippe Mathieu-Daudé
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2019-10-15 12:51 UTC (permalink / raw)
To: Ard Biesheuvel, devel; +Cc: sami.mujawar, leif.lindholm
On 10/15/19 13:07, Ard Biesheuvel wrote:
> DynamicTablesPkg can be built for ARM as well as for AARCH64, but on
> the former, doing so will result in a build failure due to the lack
> of 64-bit division helpers provided by the ArmPkg intrinsics library.
> So add the missing reference, for both ARM and AARCH64 (which may
> start relying on intrinsics due to future changes)
>
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2269
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc
> index ef958077ed48..19beaaf370f8 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.dsc
> +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc
> @@ -32,6 +32,7 @@ [LibraryClasses]
> UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
>
> [LibraryClasses.ARM, LibraryClasses.AARCH64]
> + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
>
> [Components.common]
>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build
2019-10-15 11:07 [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build Ard Biesheuvel
2019-10-15 12:21 ` Sami Mujawar
2019-10-15 12:51 ` Laszlo Ersek
@ 2019-10-16 11:51 ` Philippe Mathieu-Daudé
2019-10-21 11:17 ` Alexei Fedorov
2019-10-21 11:37 ` Sami Mujawar
4 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-16 11:51 UTC (permalink / raw)
To: devel, ard.biesheuvel; +Cc: lersek, sami.mujawar, leif.lindholm
On 10/15/19 1:07 PM, Ard Biesheuvel wrote:
> DynamicTablesPkg can be built for ARM as well as for AARCH64, but on
> the former, doing so will result in a build failure due to the lack
> of 64-bit division helpers provided by the ArmPkg intrinsics library.
> So add the missing reference, for both ARM and AARCH64 (which may
> start relying on intrinsics due to future changes)
>
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2269
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc
> index ef958077ed48..19beaaf370f8 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.dsc
> +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc
> @@ -32,6 +32,7 @@ [LibraryClasses]
> UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
>
> [LibraryClasses.ARM, LibraryClasses.AARCH64]
> + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
>
> [Components.common]
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build
2019-10-15 11:07 [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build Ard Biesheuvel
` (2 preceding siblings ...)
2019-10-16 11:51 ` [edk2-devel] " Philippe Mathieu-Daudé
@ 2019-10-21 11:17 ` Alexei Fedorov
2019-10-21 11:37 ` Sami Mujawar
4 siblings, 0 replies; 6+ messages in thread
From: Alexei Fedorov @ 2019-10-21 11:17 UTC (permalink / raw)
To: Ard Biesheuvel, devel
[-- Attachment #1: Type: text/plain, Size: 54 bytes --]
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
[-- Attachment #2: Type: text/html, Size: 60 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build
2019-10-15 11:07 [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build Ard Biesheuvel
` (3 preceding siblings ...)
2019-10-21 11:17 ` Alexei Fedorov
@ 2019-10-21 11:37 ` Sami Mujawar
4 siblings, 0 replies; 6+ messages in thread
From: Sami Mujawar @ 2019-10-21 11:37 UTC (permalink / raw)
To: Ard Biesheuvel, devel@edk2.groups.io
Cc: lersek@redhat.com, leif.lindholm@linaro.org, Alexei Fedorov,
Philippe Mathieu-Daude
Pushed as : 61bb6eeb4d93..91f98c908627
Thanks.
Regards,
Sami Mujawar
-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Sent: 15 October 2019 12:08 PM
To: devel@edk2.groups.io
Cc: lersek@redhat.com; Sami Mujawar <Sami.Mujawar@arm.com>; leif.lindholm@linaro.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build
DynamicTablesPkg can be built for ARM as well as for AARCH64, but on the former, doing so will result in a build failure due to the lack of 64-bit division helpers provided by the ArmPkg intrinsics library.
So add the missing reference, for both ARM and AARCH64 (which may start relying on intrinsics due to future changes)
Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2269
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc
index ef958077ed48..19beaaf370f8 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.dsc
+++ b/DynamicTablesPkg/DynamicTablesPkg.dsc
@@ -32,6 +32,7 @@ [LibraryClasses]
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
[LibraryClasses.ARM, LibraryClasses.AARCH64]
+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
[Components.common]
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply related [flat|nested] 6+ messages in thread