* Reminder for deleting 3 network drivers in MdeModulePkg
@ 2018-10-30 8:11 Fu, Siyuan
2018-10-30 10:46 ` Leif Lindholm
0 siblings, 1 reply; 9+ messages in thread
From: Fu, Siyuan @ 2018-10-30 8:11 UTC (permalink / raw)
To: edk2-devel@lists.01.org
Hi, All
This email is a reminder for the patch series "Delete TCP, PXE, iSCSI driver in MdeModulePkg" https://lists.01.org/pipermail/edk2-devel/2018-October/031605.html, which *intend to delete 3 network drivers from edk2 repository*. Please help to review this email and also the patch series to provide your feedback before this weekend.
Below is a driver list which we want to *delete* from edk2 master, because these drivers have not been actively maintained for a long time, and can't co-work with the dual-stack drivers in NetworkPkg.
MdeModulePkg/Universal/Network/Tcp4Dxe (will be deleted)
MdeModulePkg/Universal/Network/UefiPxeBcDxe (will be deleted)
MdeModulePkg/Universal/Network/IScsiDxe (will be deleted)
Below drivers in NetworkPkg contains all the functionalities compared with the MdeModulePkg version, with more bug fixes and more new feature added:
NetworkPkg/TcpDxe/TcpDxe.inf
NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
NetworkPkg/IScsiDxe/IScsiDxe.inf
People who want to continue use these deleted drivers could go to edk2/UDK2018 branch to get them, but it's *highly not recommended*.
*If you have any opposition on deleting these drivers, please let me know before this weekend, thanks.*
Bugzilla link for this issue:
https://bugzilla.tianocore.org/show_bug.cgi?id=1278
BestRegards
Fu Siyuan
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Reminder for deleting 3 network drivers in MdeModulePkg 2018-10-30 8:11 Reminder for deleting 3 network drivers in MdeModulePkg Fu, Siyuan @ 2018-10-30 10:46 ` Leif Lindholm 2018-10-31 0:49 ` Fu, Siyuan 2018-10-31 2:58 ` Fu, Siyuan 0 siblings, 2 replies; 9+ messages in thread From: Leif Lindholm @ 2018-10-30 10:46 UTC (permalink / raw) To: Fu, Siyuan; +Cc: edk2-devel@lists.01.org Hi Fu Siyan, On Tue, Oct 30, 2018 at 08:11:52AM +0000, Fu, Siyuan wrote: > People who want to continue use these deleted drivers could go to > edk2/UDK2018 branch to get them, but it's *highly not recommended*. They should also be able to use edk2-stable201811, right? > *If you have any opposition on deleting these drivers, please let me > know before this weekend, thanks.* I am all for this change. The diffstat is very nice :) Best Regards, Leif ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Reminder for deleting 3 network drivers in MdeModulePkg 2018-10-30 10:46 ` Leif Lindholm @ 2018-10-31 0:49 ` Fu, Siyuan 2018-10-31 2:58 ` Fu, Siyuan 1 sibling, 0 replies; 9+ messages in thread From: Fu, Siyuan @ 2018-10-31 0:49 UTC (permalink / raw) To: Leif Lindholm; +Cc: edk2-devel@lists.01.org Hi, Leif I think checking the branch is a little better than the tag, because we may still have critical bug fixes after the official release. While any of them are not recommended, always using the NetworkPkg version driver is the best choice. I will modify the edk2 network wiki page for an updated sample DSC/FDF section, if this patch could pass review w/o objection. https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg-Getting-Started-Guide BestRegards Fu Siyuan > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Leif Lindholm > Sent: Tuesday, October 30, 2018 6:47 PM > To: Fu, Siyuan <siyuan.fu@intel.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] Reminder for deleting 3 network drivers in > MdeModulePkg > > Hi Fu Siyan, > > On Tue, Oct 30, 2018 at 08:11:52AM +0000, Fu, Siyuan wrote: > > People who want to continue use these deleted drivers could go to > > edk2/UDK2018 branch to get them, but it's *highly not recommended*. > > They should also be able to use edk2-stable201811, right? > > > *If you have any opposition on deleting these drivers, please let me > > know before this weekend, thanks.* > > I am all for this change. The diffstat is very nice :) > > Best Regards, > > Leif > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Reminder for deleting 3 network drivers in MdeModulePkg 2018-10-30 10:46 ` Leif Lindholm 2018-10-31 0:49 ` Fu, Siyuan @ 2018-10-31 2:58 ` Fu, Siyuan 2018-10-31 10:50 ` Leif Lindholm 1 sibling, 1 reply; 9+ messages in thread From: Fu, Siyuan @ 2018-10-31 2:58 UTC (permalink / raw) To: Leif Lindholm; +Cc: edk2-devel@lists.01.org Hi, Leif Just notice that you are saying edk2-stable201811 tag. We need more time to collect community/marketing feedback on deleting these driver, so it may won't be able to catch the stable tag in next month. BestRegards Fu Siyuan > -----Original Message----- > From: Fu, Siyuan > Sent: Wednesday, October 31, 2018 8:49 AM > To: Leif Lindholm <leif.lindholm@linaro.org> > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] Reminder for deleting 3 network drivers in > MdeModulePkg > > Hi, Leif > > I think checking the branch is a little better than the tag, because we > may still have critical bug fixes after the official release. > > While any of them are not recommended, always using the NetworkPkg version > driver is the best choice. > > I will modify the edk2 network wiki page for an updated sample DSC/FDF > section, if this patch could pass review w/o objection. > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg-Getting- > Started-Guide > > > BestRegards > Fu Siyuan > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Leif Lindholm > > Sent: Tuesday, October 30, 2018 6:47 PM > > To: Fu, Siyuan <siyuan.fu@intel.com> > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] Reminder for deleting 3 network drivers in > > MdeModulePkg > > > > Hi Fu Siyan, > > > > On Tue, Oct 30, 2018 at 08:11:52AM +0000, Fu, Siyuan wrote: > > > People who want to continue use these deleted drivers could go to > > > edk2/UDK2018 branch to get them, but it's *highly not recommended*. > > > > They should also be able to use edk2-stable201811, right? > > > > > *If you have any opposition on deleting these drivers, please let me > > > know before this weekend, thanks.* > > > > I am all for this change. The diffstat is very nice :) > > > > Best Regards, > > > > Leif > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Reminder for deleting 3 network drivers in MdeModulePkg 2018-10-31 2:58 ` Fu, Siyuan @ 2018-10-31 10:50 ` Leif Lindholm 2018-11-01 6:01 ` Gao, Liming 0 siblings, 1 reply; 9+ messages in thread From: Leif Lindholm @ 2018-10-31 10:50 UTC (permalink / raw) To: Fu, Siyuan; +Cc: edk2-devel@lists.01.org Hi Fu Siyuan, That is fine too. But I expect the change to be one to go in the week after a stable tag has been made. (My own philosophy is that one can be quite aggressive with removals, because if it turns out to have been a bad idea, git revert can quickly restore the tree to the state it was.) Best Regards, Leif On Wed, Oct 31, 2018 at 02:58:47AM +0000, Fu, Siyuan wrote: > Hi, Leif > > Just notice that you are saying edk2-stable201811 tag. > > We need more time to collect community/marketing feedback on > deleting these driver, so it may won't be able to catch the stable > tag in next month. > > BestRegards > Fu Siyuan > > > > -----Original Message----- > > From: Fu, Siyuan > > Sent: Wednesday, October 31, 2018 8:49 AM > > To: Leif Lindholm <leif.lindholm@linaro.org> > > Cc: edk2-devel@lists.01.org > > Subject: RE: [edk2] Reminder for deleting 3 network drivers in > > MdeModulePkg > > > > Hi, Leif > > > > I think checking the branch is a little better than the tag, because we > > may still have critical bug fixes after the official release. > > > > While any of them are not recommended, always using the NetworkPkg version > > driver is the best choice. > > > > I will modify the edk2 network wiki page for an updated sample DSC/FDF > > section, if this patch could pass review w/o objection. > > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg-Getting- > > Started-Guide > > > > > > BestRegards > > Fu Siyuan > > > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > > Leif Lindholm > > > Sent: Tuesday, October 30, 2018 6:47 PM > > > To: Fu, Siyuan <siyuan.fu@intel.com> > > > Cc: edk2-devel@lists.01.org > > > Subject: Re: [edk2] Reminder for deleting 3 network drivers in > > > MdeModulePkg > > > > > > Hi Fu Siyan, > > > > > > On Tue, Oct 30, 2018 at 08:11:52AM +0000, Fu, Siyuan wrote: > > > > People who want to continue use these deleted drivers could go to > > > > edk2/UDK2018 branch to get them, but it's *highly not recommended*. > > > > > > They should also be able to use edk2-stable201811, right? > > > > > > > *If you have any opposition on deleting these drivers, please let me > > > > know before this weekend, thanks.* > > > > > > I am all for this change. The diffstat is very nice :) > > > > > > Best Regards, > > > > > > Leif > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Reminder for deleting 3 network drivers in MdeModulePkg 2018-10-31 10:50 ` Leif Lindholm @ 2018-11-01 6:01 ` Gao, Liming 2018-11-01 9:01 ` Leif Lindholm 0 siblings, 1 reply; 9+ messages in thread From: Gao, Liming @ 2018-11-01 6:01 UTC (permalink / raw) To: Leif Lindholm, Fu, Siyuan, afish@apple.com, Kinney, Michael D Cc: edk2-devel@lists.01.org, Gao, Liming Leif: If all Stewards agree this change to remove MdeModulePkg Tcp4Dxe/UefiPxeBcDxe/IScsiDxe, we will try to include it in edk2-stable201811 stable tag. Andrew and Mike: Do you agree this change to happen in near edk2-stable201811 stable tag? Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leif >Lindholm >Sent: Wednesday, October 31, 2018 6:50 PM >To: Fu, Siyuan <siyuan.fu@intel.com> >Cc: edk2-devel@lists.01.org >Subject: Re: [edk2] Reminder for deleting 3 network drivers in >MdeModulePkg > >Hi Fu Siyuan, > >That is fine too. >But I expect the change to be one to go in the week after a stable tag >has been made. > >(My own philosophy is that one can be quite aggressive with removals, >because if it turns out to have been a bad idea, git revert can >quickly restore the tree to the state it was.) > >Best Regards, > >Leif > >On Wed, Oct 31, 2018 at 02:58:47AM +0000, Fu, Siyuan wrote: >> Hi, Leif >> >> Just notice that you are saying edk2-stable201811 tag. >> >> We need more time to collect community/marketing feedback on >> deleting these driver, so it may won't be able to catch the stable >> tag in next month. >> >> BestRegards >> Fu Siyuan >> >> >> > -----Original Message----- >> > From: Fu, Siyuan >> > Sent: Wednesday, October 31, 2018 8:49 AM >> > To: Leif Lindholm <leif.lindholm@linaro.org> >> > Cc: edk2-devel@lists.01.org >> > Subject: RE: [edk2] Reminder for deleting 3 network drivers in >> > MdeModulePkg >> > >> > Hi, Leif >> > >> > I think checking the branch is a little better than the tag, because we >> > may still have critical bug fixes after the official release. >> > >> > While any of them are not recommended, always using the NetworkPkg >version >> > driver is the best choice. >> > >> > I will modify the edk2 network wiki page for an updated sample DSC/FDF >> > section, if this patch could pass review w/o objection. >> > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg- >Getting- >> > Started-Guide >> > >> > >> > BestRegards >> > Fu Siyuan >> > >> > >> > > -----Original Message----- >> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf >Of >> > > Leif Lindholm >> > > Sent: Tuesday, October 30, 2018 6:47 PM >> > > To: Fu, Siyuan <siyuan.fu@intel.com> >> > > Cc: edk2-devel@lists.01.org >> > > Subject: Re: [edk2] Reminder for deleting 3 network drivers in >> > > MdeModulePkg >> > > >> > > Hi Fu Siyan, >> > > >> > > On Tue, Oct 30, 2018 at 08:11:52AM +0000, Fu, Siyuan wrote: >> > > > People who want to continue use these deleted drivers could go to >> > > > edk2/UDK2018 branch to get them, but it's *highly not recommended*. >> > > >> > > They should also be able to use edk2-stable201811, right? >> > > >> > > > *If you have any opposition on deleting these drivers, please let me >> > > > know before this weekend, thanks.* >> > > >> > > I am all for this change. The diffstat is very nice :) >> > > >> > > Best Regards, >> > > >> > > Leif >> > > _______________________________________________ >> > > edk2-devel mailing list >> > > edk2-devel@lists.01.org >> > > https://lists.01.org/mailman/listinfo/edk2-devel >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Reminder for deleting 3 network drivers in MdeModulePkg 2018-11-01 6:01 ` Gao, Liming @ 2018-11-01 9:01 ` Leif Lindholm 2018-11-02 14:21 ` Gao, Liming 2018-11-02 15:00 ` Andrew Fish 0 siblings, 2 replies; 9+ messages in thread From: Leif Lindholm @ 2018-11-01 9:01 UTC (permalink / raw) To: Gao, Liming Cc: Fu, Siyuan, afish@apple.com, Kinney, Michael D, edk2-devel@lists.01.org On Thu, Nov 01, 2018 at 06:01:31AM +0000, Gao, Liming wrote: > Leif: > If all Stewards agree this change to remove MdeModulePkg > Tcp4Dxe/UefiPxeBcDxe/IScsiDxe, we will try to include it in > edk2-stable201811 stable tag. > > Andrew and Mike: > Do you agree this change to happen in near edk2-stable201811 > stable tag? No no no. I was suggesting deleting them immediately _after_ the stable tag (if review is complete by then). Regards, Leif > > Thanks > Liming > >-----Original Message----- > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leif > >Lindholm > >Sent: Wednesday, October 31, 2018 6:50 PM > >To: Fu, Siyuan <siyuan.fu@intel.com> > >Cc: edk2-devel@lists.01.org > >Subject: Re: [edk2] Reminder for deleting 3 network drivers in > >MdeModulePkg > > > >Hi Fu Siyuan, > > > >That is fine too. > >But I expect the change to be one to go in the week after a stable tag > >has been made. > > > >(My own philosophy is that one can be quite aggressive with removals, > >because if it turns out to have been a bad idea, git revert can > >quickly restore the tree to the state it was.) > > > >Best Regards, > > > >Leif > > > >On Wed, Oct 31, 2018 at 02:58:47AM +0000, Fu, Siyuan wrote: > >> Hi, Leif > >> > >> Just notice that you are saying edk2-stable201811 tag. > >> > >> We need more time to collect community/marketing feedback on > >> deleting these driver, so it may won't be able to catch the stable > >> tag in next month. > >> > >> BestRegards > >> Fu Siyuan > >> > >> > >> > -----Original Message----- > >> > From: Fu, Siyuan > >> > Sent: Wednesday, October 31, 2018 8:49 AM > >> > To: Leif Lindholm <leif.lindholm@linaro.org> > >> > Cc: edk2-devel@lists.01.org > >> > Subject: RE: [edk2] Reminder for deleting 3 network drivers in > >> > MdeModulePkg > >> > > >> > Hi, Leif > >> > > >> > I think checking the branch is a little better than the tag, because we > >> > may still have critical bug fixes after the official release. > >> > > >> > While any of them are not recommended, always using the NetworkPkg > >version > >> > driver is the best choice. > >> > > >> > I will modify the edk2 network wiki page for an updated sample DSC/FDF > >> > section, if this patch could pass review w/o objection. > >> > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg- > >Getting- > >> > Started-Guide > >> > > >> > > >> > BestRegards > >> > Fu Siyuan > >> > > >> > > >> > > -----Original Message----- > >> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > >Of > >> > > Leif Lindholm > >> > > Sent: Tuesday, October 30, 2018 6:47 PM > >> > > To: Fu, Siyuan <siyuan.fu@intel.com> > >> > > Cc: edk2-devel@lists.01.org > >> > > Subject: Re: [edk2] Reminder for deleting 3 network drivers in > >> > > MdeModulePkg > >> > > > >> > > Hi Fu Siyan, > >> > > > >> > > On Tue, Oct 30, 2018 at 08:11:52AM +0000, Fu, Siyuan wrote: > >> > > > People who want to continue use these deleted drivers could go to > >> > > > edk2/UDK2018 branch to get them, but it's *highly not recommended*. > >> > > > >> > > They should also be able to use edk2-stable201811, right? > >> > > > >> > > > *If you have any opposition on deleting these drivers, please let me > >> > > > know before this weekend, thanks.* > >> > > > >> > > I am all for this change. The diffstat is very nice :) > >> > > > >> > > Best Regards, > >> > > > >> > > Leif > >> > > _______________________________________________ > >> > > edk2-devel mailing list > >> > > edk2-devel@lists.01.org > >> > > https://lists.01.org/mailman/listinfo/edk2-devel > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Reminder for deleting 3 network drivers in MdeModulePkg 2018-11-01 9:01 ` Leif Lindholm @ 2018-11-02 14:21 ` Gao, Liming 2018-11-02 15:00 ` Andrew Fish 1 sibling, 0 replies; 9+ messages in thread From: Gao, Liming @ 2018-11-02 14:21 UTC (permalink / raw) To: Leif Lindholm Cc: Fu, Siyuan, afish@apple.com, Kinney, Michael D, edk2-devel@lists.01.org This plan is OK to me. Thanks Liming > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, November 1, 2018 5:02 PM > To: Gao, Liming <liming.gao@intel.com> > Cc: Fu, Siyuan <siyuan.fu@intel.com>; afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] Reminder for deleting 3 network drivers in MdeModulePkg > > On Thu, Nov 01, 2018 at 06:01:31AM +0000, Gao, Liming wrote: > > Leif: > > If all Stewards agree this change to remove MdeModulePkg > > Tcp4Dxe/UefiPxeBcDxe/IScsiDxe, we will try to include it in > > edk2-stable201811 stable tag. > > > > Andrew and Mike: > > Do you agree this change to happen in near edk2-stable201811 > > stable tag? > > No no no. I was suggesting deleting them immediately _after_ the > stable tag (if review is complete by then). > > Regards, > > Leif > > > > > Thanks > > Liming > > >-----Original Message----- > > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leif > > >Lindholm > > >Sent: Wednesday, October 31, 2018 6:50 PM > > >To: Fu, Siyuan <siyuan.fu@intel.com> > > >Cc: edk2-devel@lists.01.org > > >Subject: Re: [edk2] Reminder for deleting 3 network drivers in > > >MdeModulePkg > > > > > >Hi Fu Siyuan, > > > > > >That is fine too. > > >But I expect the change to be one to go in the week after a stable tag > > >has been made. > > > > > >(My own philosophy is that one can be quite aggressive with removals, > > >because if it turns out to have been a bad idea, git revert can > > >quickly restore the tree to the state it was.) > > > > > >Best Regards, > > > > > >Leif > > > > > >On Wed, Oct 31, 2018 at 02:58:47AM +0000, Fu, Siyuan wrote: > > >> Hi, Leif > > >> > > >> Just notice that you are saying edk2-stable201811 tag. > > >> > > >> We need more time to collect community/marketing feedback on > > >> deleting these driver, so it may won't be able to catch the stable > > >> tag in next month. > > >> > > >> BestRegards > > >> Fu Siyuan > > >> > > >> > > >> > -----Original Message----- > > >> > From: Fu, Siyuan > > >> > Sent: Wednesday, October 31, 2018 8:49 AM > > >> > To: Leif Lindholm <leif.lindholm@linaro.org> > > >> > Cc: edk2-devel@lists.01.org > > >> > Subject: RE: [edk2] Reminder for deleting 3 network drivers in > > >> > MdeModulePkg > > >> > > > >> > Hi, Leif > > >> > > > >> > I think checking the branch is a little better than the tag, because we > > >> > may still have critical bug fixes after the official release. > > >> > > > >> > While any of them are not recommended, always using the NetworkPkg > > >version > > >> > driver is the best choice. > > >> > > > >> > I will modify the edk2 network wiki page for an updated sample DSC/FDF > > >> > section, if this patch could pass review w/o objection. > > >> > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg- > > >Getting- > > >> > Started-Guide > > >> > > > >> > > > >> > BestRegards > > >> > Fu Siyuan > > >> > > > >> > > > >> > > -----Original Message----- > > >> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > >Of > > >> > > Leif Lindholm > > >> > > Sent: Tuesday, October 30, 2018 6:47 PM > > >> > > To: Fu, Siyuan <siyuan.fu@intel.com> > > >> > > Cc: edk2-devel@lists.01.org > > >> > > Subject: Re: [edk2] Reminder for deleting 3 network drivers in > > >> > > MdeModulePkg > > >> > > > > >> > > Hi Fu Siyan, > > >> > > > > >> > > On Tue, Oct 30, 2018 at 08:11:52AM +0000, Fu, Siyuan wrote: > > >> > > > People who want to continue use these deleted drivers could go to > > >> > > > edk2/UDK2018 branch to get them, but it's *highly not recommended*. > > >> > > > > >> > > They should also be able to use edk2-stable201811, right? > > >> > > > > >> > > > *If you have any opposition on deleting these drivers, please let me > > >> > > > know before this weekend, thanks.* > > >> > > > > >> > > I am all for this change. The diffstat is very nice :) > > >> > > > > >> > > Best Regards, > > >> > > > > >> > > Leif > > >> > > _______________________________________________ > > >> > > edk2-devel mailing list > > >> > > edk2-devel@lists.01.org > > >> > > https://lists.01.org/mailman/listinfo/edk2-devel > > >_______________________________________________ > > >edk2-devel mailing list > > >edk2-devel@lists.01.org > > >https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Reminder for deleting 3 network drivers in MdeModulePkg 2018-11-01 9:01 ` Leif Lindholm 2018-11-02 14:21 ` Gao, Liming @ 2018-11-02 15:00 ` Andrew Fish 1 sibling, 0 replies; 9+ messages in thread From: Andrew Fish @ 2018-11-02 15:00 UTC (permalink / raw) To: Leif Lindholm Cc: Gao, Liming, Fu, Siyuan, Mike Kinney, edk2-devel@lists.01.org > On Nov 1, 2018, at 2:01 AM, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > On Thu, Nov 01, 2018 at 06:01:31AM +0000, Gao, Liming wrote: >> Leif: >> If all Stewards agree this change to remove MdeModulePkg >> Tcp4Dxe/UefiPxeBcDxe/IScsiDxe, we will try to include it in >> edk2-stable201811 stable tag. >> >> Andrew and Mike: >> Do you agree this change to happen in near edk2-stable201811 >> stable tag? > > No no no. I was suggesting deleting them immediately _after_ the > stable tag (if review is complete by then). > Sounds good to me too. Thanks, Andrew Fish > Regards, > > Leif > >> >> Thanks >> Liming >>> -----Original Message----- >>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leif >>> Lindholm >>> Sent: Wednesday, October 31, 2018 6:50 PM >>> To: Fu, Siyuan <siyuan.fu@intel.com> >>> Cc: edk2-devel@lists.01.org >>> Subject: Re: [edk2] Reminder for deleting 3 network drivers in >>> MdeModulePkg >>> >>> Hi Fu Siyuan, >>> >>> That is fine too. >>> But I expect the change to be one to go in the week after a stable tag >>> has been made. >>> >>> (My own philosophy is that one can be quite aggressive with removals, >>> because if it turns out to have been a bad idea, git revert can >>> quickly restore the tree to the state it was.) >>> >>> Best Regards, >>> >>> Leif >>> >>> On Wed, Oct 31, 2018 at 02:58:47AM +0000, Fu, Siyuan wrote: >>>> Hi, Leif >>>> >>>> Just notice that you are saying edk2-stable201811 tag. >>>> >>>> We need more time to collect community/marketing feedback on >>>> deleting these driver, so it may won't be able to catch the stable >>>> tag in next month. >>>> >>>> BestRegards >>>> Fu Siyuan >>>> >>>> >>>>> -----Original Message----- >>>>> From: Fu, Siyuan >>>>> Sent: Wednesday, October 31, 2018 8:49 AM >>>>> To: Leif Lindholm <leif.lindholm@linaro.org> >>>>> Cc: edk2-devel@lists.01.org >>>>> Subject: RE: [edk2] Reminder for deleting 3 network drivers in >>>>> MdeModulePkg >>>>> >>>>> Hi, Leif >>>>> >>>>> I think checking the branch is a little better than the tag, because we >>>>> may still have critical bug fixes after the official release. >>>>> >>>>> While any of them are not recommended, always using the NetworkPkg >>> version >>>>> driver is the best choice. >>>>> >>>>> I will modify the edk2 network wiki page for an updated sample DSC/FDF >>>>> section, if this patch could pass review w/o objection. >>>>> https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg- >>> Getting- >>>>> Started-Guide >>>>> >>>>> >>>>> BestRegards >>>>> Fu Siyuan >>>>> >>>>> >>>>>> -----Original Message----- >>>>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf >>> Of >>>>>> Leif Lindholm >>>>>> Sent: Tuesday, October 30, 2018 6:47 PM >>>>>> To: Fu, Siyuan <siyuan.fu@intel.com> >>>>>> Cc: edk2-devel@lists.01.org >>>>>> Subject: Re: [edk2] Reminder for deleting 3 network drivers in >>>>>> MdeModulePkg >>>>>> >>>>>> Hi Fu Siyan, >>>>>> >>>>>> On Tue, Oct 30, 2018 at 08:11:52AM +0000, Fu, Siyuan wrote: >>>>>>> People who want to continue use these deleted drivers could go to >>>>>>> edk2/UDK2018 branch to get them, but it's *highly not recommended*. >>>>>> >>>>>> They should also be able to use edk2-stable201811, right? >>>>>> >>>>>>> *If you have any opposition on deleting these drivers, please let me >>>>>>> know before this weekend, thanks.* >>>>>> >>>>>> I am all for this change. The diffstat is very nice :) >>>>>> >>>>>> Best Regards, >>>>>> >>>>>> Leif >>>>>> _______________________________________________ >>>>>> edk2-devel mailing list >>>>>> edk2-devel@lists.01.org >>>>>> https://lists.01.org/mailman/listinfo/edk2-devel >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-11-02 15:01 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-10-30 8:11 Reminder for deleting 3 network drivers in MdeModulePkg Fu, Siyuan 2018-10-30 10:46 ` Leif Lindholm 2018-10-31 0:49 ` Fu, Siyuan 2018-10-31 2:58 ` Fu, Siyuan 2018-10-31 10:50 ` Leif Lindholm 2018-11-01 6:01 ` Gao, Liming 2018-11-01 9:01 ` Leif Lindholm 2018-11-02 14:21 ` Gao, Liming 2018-11-02 15:00 ` Andrew Fish
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox