From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 72BE1211BA44B for ; Fri, 18 Jan 2019 17:17:23 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4558B750C8; Sat, 19 Jan 2019 01:17:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-125-168.rdu2.redhat.com [10.10.125.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id 73C75608C4; Sat, 19 Jan 2019 01:17:20 +0000 (UTC) To: Ard Biesheuvel , "Gao, Liming" Cc: "Wu, Jiaxin" , "Fu, Siyuan" , "Wu, Hao A" , "edk2-devel@lists.01.org" , "Ye, Ting" References: <20190118051612.9600-1-Jiaxin.wu@intel.com> <895558F6EA4E3B41AC93A00D163B727416EC67B5@SHSMSX107.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B4596@SHSMSX152.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <70bb0ff8-09fe-42c9-0152-ffed039033bd@redhat.com> Date: Sat, 19 Jan 2019 02:17:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 19 Jan 2019 01:17:23 +0000 (UTC) Subject: Re: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jan 2019 01:17:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/18/19 12:09, Ard Biesheuvel wrote: > On Fri, 18 Jan 2019 at 06:38, Gao, Liming wrote: >> >> This is my idea to avoid the duplicated mail. I also include Ard and Laszlo to collect the feedback on how to handle the partial update in the patchset. >> > > Laszlo may disagree with me, but I think that it is not always > necessary to resend the entire series when only a single patch > changes. It does depend on the situation, though: if it is a trivial > patch in a more complicated series then it might make little sense. In > other case, just resending the whole thing is probably better. I think resending one patch can be acceptable, but the subject line (patch nr) and the threading have to be correct. Also, I don't think this approach scales beyond exactly one patch-update; it's easy to lose track of version numbers etc. So "use sparingly" I guess? :) Thanks Laszlo > > >>> -----Original Message----- >>> From: Wu, Jiaxin >>> Sent: Friday, January 18, 2019 1:32 PM >>> To: Fu, Siyuan ; Wu, Hao A ; edk2-devel@lists.01.org >>> Cc: Ye, Ting ; Gao, Liming >>> Subject: RE: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check. >>> >>> Just confirmed with Liming, we don't need to seed the full series patches if only one is updated. >>> >>> Thanks, >>> jiaxin >>> >>>> -----Original Message----- >>>> From: Fu, Siyuan >>>> Sent: Friday, January 18, 2019 1:29 PM >>>> To: Wu, Hao A ; Wu, Jiaxin ; >>>> edk2-devel@lists.01.org >>>> Cc: Ye, Ting ; Gao, Liming >>>> Subject: RE: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove >>>> unnecessary NULL pointer check. >>>> >>>> Hi, Jiaxin >>>> >>>> Yes the full patch series is needed for a v2 version. >>>> >>>> And also, why you removed the "(Instance->Token != NULL)" check in the if >>>> condition? >>>> >>>> BestRegards >>>> Fu Siyuan >>>> >>>> >>>>> -----Original Message----- >>>>> From: Wu, Hao A >>>>> Sent: Friday, January 18, 2019 1:22 PM >>>>> To: Wu, Jiaxin ; edk2-devel@lists.01.org >>>>> Cc: Ye, Ting ; Fu, Siyuan ; Gao, >>>>> Liming >>>>> Subject: RE: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove >>>> unnecessary NULL >>>>> pointer check. >>>>> >>>>> Hi Jiaxin, >>>>> >>>>> A comment that is not related with the content of the patch itself: >>>>> Please help to send the full patch series when a new version is needed. >>>>> >>>>> Best Regards, >>>>> Hao Wu >>>>> >>>>>> -----Original Message----- >>>>>> From: Wu, Jiaxin >>>>>> Sent: Friday, January 18, 2019 1:16 PM >>>>>> To: edk2-devel@lists.01.org >>>>>> Cc: Ye, Ting; Fu, Siyuan; Wu, Hao A; Gao, Liming; Wu, Jiaxin >>>>>> Subject: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove >>>> unnecessary >>>>>> NULL pointer check. >>>>>> >>>>>> v2: The DHCP Instance might be destroyed in PxeDhcpDone. So, >>>>>> we need safe-delete. >>>>>> >>>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469 >>>>>> >>>>>> Since the value of Instance is retrieved from the list Entry, >>>>>> it can't be the NULL pointer, so just remove the unnecessary >>>>>> check. >>>>>> >>>>>> Cc: Ye Ting >>>>>> Cc: Fu Siyuan >>>>>> Cc: Wu Hao A >>>>>> Cc: Gao Liming >>>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>>> Signed-off-by: Wu Jiaxin >>>>>> --- >>>>>> MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c | 11 ++++----- >>>> -- >>>>>> 1 file changed, 4 insertions(+), 7 deletions(-) >>>>>> >>>>>> diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c >>>>>> b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c >>>>>> index 98a22a77b4..780f8b4224 100644 >>>>>> --- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c >>>>>> +++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c >>>>>> @@ -1,9 +1,9 @@ >>>>>> /** @file >>>>>> EFI DHCP protocol implementation. >>>>>> >>>>>> -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
>>>>>> +Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
>>>>>> This program and the accompanying materials >>>>>> are licensed and made available under the terms and conditions of the >>>> BSD >>>>>> License >>>>>> which accompanies this distribution. The full text of the license may be >>>>>> found at >>>>>> http://opensource.org/licenses/bsd-license.php >>>>>> >>>>>> @@ -1646,16 +1646,13 @@ ON_EXIT: >>>>>> // >>>>>> // Iterate through all the DhcpSb Children. >>>>>> // >>>>>> NET_LIST_FOR_EACH_SAFE (Entry, Next, &DhcpSb->Children) { >>>>>> Instance = NET_LIST_USER_STRUCT (Entry, DHCP_PROTOCOL, Link); >>>>>> - >>>>>> - if ((Instance != NULL) && (Instance->Token != NULL)) { >>>>>> - Instance->Timeout--; >>>>>> - if (Instance->Timeout == 0) { >>>>>> - PxeDhcpDone (Instance); >>>>>> - } >>>>>> + Instance->Timeout--; >>>>>> + if (Instance->Timeout == 0) { >>>>>> + PxeDhcpDone (Instance); >>>>>> } >>>>>> } >>>>>> >>>>>> return ; >>>>>> >>>>>> -- >>>>>> 2.17.1.windows.2 >>