Re: [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger

[Pete Batard <pete@akeo.ie>]

On 2016.11.14 13:58, Yao, Jiewen wrote:
> One minor concern I have is that: I found you include below in
> Protocol/Ebc.h
>
> #define GETOPERANDS(pVM)  (UINT8) (*(UINT8 *) (pVM->Ip + 1))
> #define GETOPCODE(pVM)    (UINT8) (*(UINT8 *) pVM->Ip)
> #define OPERAND1_REGDATA(pvm, op) pvm->Gpr[OPERAND1_REGNUM (op)]
> #define OPERAND2_REGDATA(pvm, op) pvm->Gpr[OPERAND2_REGNUM (op)]
>
> However, pvm->Gpr and pVM->Ip are defined in Protocol/EbcVmTest.h.
>
> I recommend that we had better move PVM related definition there.

I agree. Do you want me to re-send a patch for that?

On that subject, I've also been wondering on whether we might just move 
all the operand related definitions into EbcVmTest.h and leave Ebc.h as 
it was.

The more I think about it, the more I wonder if a header that's just 
meant to define the EBC interpreter interface is the best place to have 
EBC internal definitions. Maybe the header that is intended for use for 
the actual implementation of the EBC VM (EbcVmTest.h) is where we should 
move everything into?

Regards,

/Pete