From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CBB3681E12 for ; Mon, 14 Nov 2016 06:11:06 -0800 (PST) Received: by mail-wm0-x233.google.com with SMTP id a197so100062367wmd.0 for ; Mon, 14 Nov 2016 06:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=zFWxzp8WErFA7+Js47F2jgad7REjWiZlTccjEz5daww=; b=1vwjMzCBa/5hnRmpi0yNdN/auaVBPNpqzig6wND8kWAIdzWk3LiiEO1EtRPXzC2Q/O EhYoxfPfxfk0Chj6J1mHqzF3nRwJNkMS1TGizqbazon+RvEodBbcgbnCVCZRFtEWT7+F 62+FzMqIU9neRZXfGnW8JEsW5VsUggb71ShujyiEoto3NHQ1amPm5UheWHbtbvFwceTP qRFHlx1SCr/lgPhqXpxiwEDdvuBcnFgobPf9pyTv0cjZtj7y0kuT2nRYwZFTjeKBmvFK Eq4FJ7dyD4IWc+eW7Th6X1bRitqyTis/xtnhUwxDM2I7/eNae8bGF4vucoXJvGMXkXuD 6+lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=zFWxzp8WErFA7+Js47F2jgad7REjWiZlTccjEz5daww=; b=YrRLhG9LAO1YdyzXbU6Z4XDsVXA0iEynyRbNxSxsfx36GOfP3qNt81kB/fNJ2aYVk7 U5AlxC1BLqFANwsHvT4qAJzFb3NI3rPp5+2/mKFEs+SqaDePHsY090FNAzXR3QN+NqsT dBOLAddVZfjpAMttt1xWDWdBoQ4UDqXEj7Dn2IteyiuviEXV/soMn1aWuTV+N6q9IJSd p9H4j27Pk1fekg4x/RKHsBrQZd+EEjywqiHb5pGlYPTMb7f+m2+C901tt000ZVbQDaER FVVpPSvDUvqeac/J0op8yXw6J9sbT1TLgwHI6C5L6mKXIuWfDC3GIR5Y3UYQOLPAfLpb olTg== X-Gm-Message-State: ABUngve5FDr7reKHryma45BFNN4kQVEdFnEtNP7XX5MxIy0/GGJQFgxrs7GrntJ7GHTAeQ== X-Received: by 10.28.20.70 with SMTP id 67mr10001301wmu.102.1479132669932; Mon, 14 Nov 2016 06:11:09 -0800 (PST) Received: from [10.0.0.101] ([84.203.71.247]) by smtp.googlemail.com with ESMTPSA id d64sm36461226wmh.3.2016.11.14.06.11.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Nov 2016 06:11:09 -0800 (PST) To: "Yao, Jiewen" , Laszlo Ersek References: <637b6291-5132-a825-3207-dbae9b586228@redhat.com> <3fa49493-5d95-6fce-a92e-7c1c73f65a5f@redhat.com> <9f4d4fac-a603-ee66-aad3-e4fcd0a57c8d@akeo.ie> <74D8A39837DF1E4DA445A8C0B3885C50386D0543@shsmsx102.ccr.corp.intel.com> Cc: "Kinney, Michael D" , "edk2-devel@lists.01.org" From: Pete Batard Message-ID: <70ceee92-2fc0-ef63-bbfd-50f4f71cab75@akeo.ie> Date: Mon, 14 Nov 2016 14:11:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386D0543@shsmsx102.ccr.corp.intel.com> Subject: Re: [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 14:11:07 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 2016.11.14 13:58, Yao, Jiewen wrote: > One minor concern I have is that: I found you include below in > Protocol/Ebc.h > > #define GETOPERANDS(pVM) (UINT8) (*(UINT8 *) (pVM->Ip + 1)) > #define GETOPCODE(pVM) (UINT8) (*(UINT8 *) pVM->Ip) > #define OPERAND1_REGDATA(pvm, op) pvm->Gpr[OPERAND1_REGNUM (op)] > #define OPERAND2_REGDATA(pvm, op) pvm->Gpr[OPERAND2_REGNUM (op)] > > However, pvm->Gpr and pVM->Ip are defined in Protocol/EbcVmTest.h. > > I recommend that we had better move PVM related definition there. I agree. Do you want me to re-send a patch for that? On that subject, I've also been wondering on whether we might just move all the operand related definitions into EbcVmTest.h and leave Ebc.h as it was. The more I think about it, the more I wonder if a header that's just meant to define the EBC interpreter interface is the best place to have EBC internal definitions. Maybe the header that is intended for use for the actual implementation of the EBC VM (EbcVmTest.h) is where we should move everything into? Regards, /Pete