From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, devel@edk2.groups.io
Cc: leif@nuviainc.com,
Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>,
Masahisa Kojima <masahisa.kojima@linaro.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] ArmPlatformPkg/NorFlashDxe: use correct PCD accessors
Date: Tue, 12 Jan 2021 13:10:07 +0100 [thread overview]
Message-ID: <70d8df1b-1d91-466f-146b-b4e3fe12dae9@arm.com> (raw)
In-Reply-To: <3c9fc9ef-30e0-5cf7-a64c-9cf40eaa69e9@redhat.com>
On 1/12/21 12:42 PM, Philippe Mathieu-Daudé wrote:
> Hi Ard,
>
> On 1/11/21 11:57 AM, Ard Biesheuvel wrote:
>> Commit 8015f3f6d4005d83 ("ArmPlatformPkg: Enable support for flash in
>> 64-bit address space") updated the NorFlash DXE and StMM drivers to
>> take alternate PCDs into account when discovering the base of the
>> NOR flash regions.
>>
>> This introduced a disparity between the declarations of the PCD references
>> in the .INF files, which permits the use of dynamic PCDs, and the code
>> itself, which now uses FixedPcdGet() accessors. On platforms that actually
>> use dynamic PCDs, this results in a build error.
>
> So there is no (mainstream) CI coverage for these platforms?
> Could we add at least one?
>
We could. It was KvmTool.dsc, which lives in the main repo.
next prev parent reply other threads:[~2021-01-12 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 10:57 [PATCH] ArmPlatformPkg/NorFlashDxe: use correct PCD accessors Ard Biesheuvel
2021-01-11 15:54 ` [edk2-devel] " Laszlo Ersek
2021-01-12 11:13 ` Vijayenthiran Subramaniam
2021-01-12 11:42 ` Philippe Mathieu-Daudé
2021-01-12 12:10 ` Ard Biesheuvel [this message]
2021-01-12 12:20 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70d8df1b-1d91-466f-146b-b4e3fe12dae9@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox