From: Laszlo Ersek <lersek@redhat.com>
To: shenglei <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Jaben Carsey <jaben.carsey@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>
Subject: Re: [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs
Date: Wed, 29 Aug 2018 15:43:49 +0200 [thread overview]
Message-ID: <70dfa56d-6781-e8c0-f3f4-aa12558672b9@redhat.com> (raw)
In-Reply-To: <20180828034257.19060-14-shenglei.zhang@intel.com>
On 08/28/18 05:42, shenglei wrote:
> The PCDs below are unused, so they have been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
> gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> ShellPkg/Application/Shell/Shell.inf | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/Shell.inf b/ShellPkg/Application/Shell/Shell.inf
> index d89f85bb76..83049844d6 100644
> --- a/ShellPkg/Application/Shell/Shell.inf
> +++ b/ShellPkg/Application/Shell/Shell.inf
> @@ -102,10 +102,8 @@
> gEfiShellPkgTokenSpaceGuid.PcdShellRequireHiiPlatform ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellSupportFrameworkHii ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2018-08-29 13:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
2018-08-28 3:42 ` [PATCH v3 01/16] IntelFsp2Pkg/FspSecCore: Remove " shenglei
2018-08-28 3:42 ` [PATCH v3 02/16] IntelFsp2Pkg/BaseFspCommonLib: " shenglei
2018-08-28 3:42 ` [PATCH v3 03/16] IntelFsp2Pkg/BaseFspPlatformLib: " shenglei
2018-08-28 3:42 ` [PATCH v3 04/16] IntelFsp2Pkg/BaseFspSwitchStackLib: " shenglei
2018-08-28 3:42 ` [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD shenglei
2018-08-28 5:28 ` Chiu, Chasel
2018-08-28 3:42 ` [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs shenglei
2018-08-28 5:30 ` Chiu, Chasel
2018-08-28 3:42 ` [PATCH v3 07/16] SecurityPkg/Tcg2ConfigPei: Remove an unused PCD shenglei
2018-08-28 3:42 ` [PATCH v3 08/16] SecurityPkg/Tcg2Dxe: Remove unused PCDs shenglei
2018-08-29 13:41 ` Laszlo Ersek
2018-08-28 3:42 ` [PATCH v3 09/16] UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD shenglei
2018-08-28 3:42 ` [PATCH v3 10/16] MdePkg/BaseLib: " shenglei
2018-08-28 3:42 ` [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs shenglei
2018-08-28 4:53 ` Zeng, Star
2018-08-28 3:42 ` [PATCH v3 12/16] MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused PCD shenglei
2018-08-28 3:42 ` [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs shenglei
2018-08-29 1:36 ` Ni, Ruiyu
2018-08-29 13:43 ` Laszlo Ersek [this message]
2018-08-28 3:42 ` [PATCH v3 14/16] ShellPkg/DpDynamicCommand: " shenglei
2018-08-29 1:36 ` Ni, Ruiyu
2018-08-28 3:42 ` [PATCH v3 15/16] ShellPkg/UefiHandleParsingLib: Remove an unused PCD shenglei
2018-08-29 13:49 ` Laszlo Ersek
2018-08-28 3:42 ` [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs shenglei
2018-08-29 1:37 ` Ni, Ruiyu
2018-08-29 13:50 ` Laszlo Ersek
2018-08-28 14:56 ` [PATCH v3 00/16] Removed " Carsey, Jaben
2018-10-02 10:13 ` Laszlo Ersek
2018-10-08 2:14 ` Zhang, Shenglei
2018-10-08 3:07 ` Ni, Ruiyu
2018-10-08 12:12 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70dfa56d-6781-e8c0-f3f4-aa12558672b9@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox