From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 05B7421959CB2 for ; Wed, 29 Aug 2018 06:43:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A67940216E8; Wed, 29 Aug 2018 13:43:51 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-221.rdu2.redhat.com [10.10.120.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B5F91054E75; Wed, 29 Aug 2018 13:43:50 +0000 (UTC) To: shenglei , edk2-devel@lists.01.org Cc: Jaben Carsey , Ruiyu Ni References: <20180828034257.19060-1-shenglei.zhang@intel.com> <20180828034257.19060-14-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: <70dfa56d-6781-e8c0-f3f4-aa12558672b9@redhat.com> Date: Wed, 29 Aug 2018 15:43:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180828034257.19060-14-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 29 Aug 2018 13:43:51 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 29 Aug 2018 13:43:51 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 13:43:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/28/18 05:42, shenglei wrote: > The PCDs below are unused, so they have been removed from inf. > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize > gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > Reviewed-by: Ruiyu Ni > --- > ShellPkg/Application/Shell/Shell.inf | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/ShellPkg/Application/Shell/Shell.inf b/ShellPkg/Application/Shell/Shell.inf > index d89f85bb76..83049844d6 100644 > --- a/ShellPkg/Application/Shell/Shell.inf > +++ b/ShellPkg/Application/Shell/Shell.inf > @@ -102,10 +102,8 @@ > gEfiShellPkgTokenSpaceGuid.PcdShellRequireHiiPlatform ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellSupportFrameworkHii ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault ## CONSUMES > - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount ## CONSUMES > - gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES > Reviewed-by: Laszlo Ersek