Re: [edk2-devel] [PATCH v2 19/25] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

["Taylor Beebe" <taylor.d.beebe@gmail.com>]

On 8/29/23 3:46 AM, Gerd Hoffmann wrote:
>
>> --- a/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h
>> +++ b/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h
>> @@ -17,6 +17,10 @@ typedef struct {
>>   } DXE_MEMORY_PROTECTION_PROFILES;
>>   
>>   typedef enum {
>> +  DxeMemoryProtectionSettingsDebug = 0,
>> +  DxeMemoryProtectionSettingsRelease,
>> +  DxeMemoryProtectionSettingsReleaseNoPageGuards,
>> +  DxeMemoryProtectionSettingsOff,
>>     DxeMemoryProtectionSettingsPcd,
>>     DxeMemoryProtectionSettingsMax
>>   } DXE_MEMORY_PROTECTION_PROFILE_INDEX;
> Ordering mismatch for "pcd" and "off".
>
> I'd suggest to use C99 initializers, i.e.
>
> 	DxeMemoryProtectionProfiles[] = {
> 		[ DxeMemoryProtectionSettingsDebug ] = {
> 			.Name = "Debug",
>
> to avoid that.
>
> take care,
>    Gerd


Thanks! Will fix in v3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108097): https://edk2.groups.io/g/devel/message/108097
Mute This Topic: https://groups.io/mt/100830918/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-