From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F10BA941CEA for ; Tue, 29 Aug 2023 16:08:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jpdjeHGZbpWBLyGGQBMuK3RN19OhZ9dOsO8StS/uesI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693325321; v=1; b=V4NLBA7VIIrnJw6AWRl/nqDxa3bYDX/08hXlJbrU2vEe2OsRGekVJcDMq2f5WB39RhTfS3lK FyQ7QqX4oQnFwVnW8sXCaaD9tckgs73h6QOvfypIwhpi+nQmLWebwQlYRI1q18v6jdeWZpADAch 2pZX1njgYW2ZnXPW/4JYwOrM= X-Received: by 127.0.0.2 with SMTP id GSTfYY7687511xHIvsQmR1OH; Tue, 29 Aug 2023 09:08:41 -0700 X-Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mx.groups.io with SMTP id smtpd.web11.924.1693325320978423270 for ; Tue, 29 Aug 2023 09:08:41 -0700 X-Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-686be3cbea0so3684239b3a.0 for ; Tue, 29 Aug 2023 09:08:40 -0700 (PDT) X-Gm-Message-State: FQC3QxEqtmk9QQZpFtMC5weKx7686176AA= X-Google-Smtp-Source: AGHT+IEf5NR6jpx9Sf+63F4o3MjR2Ut5BIy+eFzyXxLF1EnMrM91E2VdC0qtrN4a4xKmZqjs4+ahjg== X-Received: by 2002:a05:6a20:938c:b0:135:bf8d:b758 with SMTP id x12-20020a056a20938c00b00135bf8db758mr4692005pzh.16.1693325320093; Tue, 29 Aug 2023 09:08:40 -0700 (PDT) X-Received: from [192.168.0.233] ([50.46.253.1]) by smtp.gmail.com with ESMTPSA id r30-20020a638f5e000000b005641bbe783bsm9156287pgn.11.2023.08.29.09.08.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 09:08:39 -0700 (PDT) Message-ID: <70ef22ad-5dba-494d-b607-4b10279a78b7@gmail.com> Date: Tue, 29 Aug 2023 09:08:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 19/25] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib To: Gerd Hoffmann , devel@edk2.groups.io Cc: Jian J Wang , Liming Gao References: <20230818223159.1073-1-taylor.d.beebe@gmail.com> <20230818223159.1073-20-taylor.d.beebe@gmail.com> <527awt5twopgc2e5wvkfmom7adrwqoltafrooqvorbwd65efjb@boftzx2w2pxn> From: "Taylor Beebe" In-Reply-To: <527awt5twopgc2e5wvkfmom7adrwqoltafrooqvorbwd65efjb@boftzx2w2pxn> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,taylor.d.beebe@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=V4NLBA7V; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 8/29/23 3:46 AM, Gerd Hoffmann wrote: > >> --- a/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h >> +++ b/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h >> @@ -17,6 +17,10 @@ typedef struct { >> } DXE_MEMORY_PROTECTION_PROFILES; >> =20 >> typedef enum { >> + DxeMemoryProtectionSettingsDebug =3D 0, >> + DxeMemoryProtectionSettingsRelease, >> + DxeMemoryProtectionSettingsReleaseNoPageGuards, >> + DxeMemoryProtectionSettingsOff, >> DxeMemoryProtectionSettingsPcd, >> DxeMemoryProtectionSettingsMax >> } DXE_MEMORY_PROTECTION_PROFILE_INDEX; > Ordering mismatch for "pcd" and "off". > > I'd suggest to use C99 initializers, i.e. > > DxeMemoryProtectionProfiles[] =3D { > [ DxeMemoryProtectionSettingsDebug ] =3D { > .Name =3D "Debug", > > to avoid that. > > take care, > Gerd Thanks! Will fix in v3 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108097): https://edk2.groups.io/g/devel/message/108097 Mute This Topic: https://groups.io/mt/100830918/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-