From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 05 Sep 2019 12:01:53 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A62BB3DE0B; Thu, 5 Sep 2019 19:01:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-133.ams2.redhat.com [10.36.116.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id 453665D9CA; Thu, 5 Sep 2019 19:01:51 +0000 (UTC) Subject: Re: [edk2-devel] [patch 2/3] MdeModulePkg: Unload image on EFI_SECURITY_VIOLATION To: devel@edk2.groups.io, dandan.bi@intel.com, "Wu, Hao A" Cc: "Wang, Jian J" , "Ni, Ray" , "Gao, Liming" References: <20190904082555.35424-1-dandan.bi@intel.com> <20190904082555.35424-3-dandan.bi@intel.com> <3C0D5C461C9E904E8F62152F6274C0BB40C57431@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <7104ff27-dcfb-8ad1-b825-6bd2cd01b5ed@redhat.com> Date: Thu, 5 Sep 2019 21:01:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40C57431@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 05 Sep 2019 19:01:52 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit just a meta comment: On 09/05/19 08:23, Dandan Bi wrote: >> -----Original Message----- >> From: Wu, Hao A >> Sent: Thursday, September 5, 2019 1:38 PM >> To: Bi, Dandan ; devel@edk2.groups.io >> Cc: Wang, Jian J ; Ni, Ray ; Gao, >> Liming ; Laszlo Ersek >> Subject: RE: [patch 2/3] MdeModulePkg: Unload image on >> EFI_SECURITY_VIOLATION >> >>> -----Original Message----- >>> From: Bi, Dandan >>> Sent: Wednesday, September 04, 2019 4:26 PM >>> To: devel@edk2.groups.io >>> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Gao, Liming; Laszlo Ersek >>> Subject: [patch 2/3] MdeModulePkg: Unload image on >>> EFI_SECURITY_VIOLATION >>> MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 9 >>> +++++++++ >>> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 9 >>> +++++++++ >>> MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 >> +++++++++ >>> .../Library/UefiBootManagerLib/BmLoadOption.c | 11 ++++++++++- >>> MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c | 11 >>> ++++++++++- >>> .../PlatformDriOverrideDxe/PlatDriOverrideLib.c | 11 ++++++++++- >> Also, since the patch is touching multiple features (PCI, Capsule, BM and >> driver override), I would suggest to break this patch into multiple ones so >> that it will be more clear to evaluate the impact for each change. >> > I will separate the patch into module level and send the new patch series. Yes, do that please, especially because now we have fine-grained maintainership assignments in "Maintainers.txt" (not for all packages, but certainly for MdeModulePkg), and a python script to assign reviewers. Let's say, you have three patches in the series, on your topic branch. You can do: $ python BaseTools/Scripts/GetMaintainer.py HEAD~2 $ python BaseTools/Scripts/GetMaintainer.py HEAD~1 $ python BaseTools/Scripts/GetMaintainer.py HEAD Each invocation will give you the list of people that you should CC on that particular patch. You can also invoke the script with the "-l" option, to get reviewers for a specific file: $ python BaseTools/Scripts/GetMaintainer.py \ -l MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c $ python BaseTools/Scripts/GetMaintainer.py \ -l MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c Other than this, I'll skip the review of patches #2 and #3 in this series; I've got too many things to do, and I'm not a designated reviewer / maintainer on either module being modified. I hope that's acceptable. Thanks, Laszlo