public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Lou, Yun" <yun.lou@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib.
Date: Fri, 9 Apr 2021 15:43:39 +0200	[thread overview]
Message-ID: <710dd775-5380-942b-7981-c67c5bcdb584@redhat.com> (raw)
In-Reply-To: <CO1PR11MB49304502A3F3452CDB0EED028C739@CO1PR11MB4930.namprd11.prod.outlook.com>

Hi Ray,

On 04/09/21 02:45, Ni, Ray wrote:
> Laszlo,
> OVMF isn't using this timerlib so I will assume you doesn't care about
> this change.

correct; that's why I gave my ACK for v1 in last September [1] [2] [3]
-- I didn't want to block progress on this patch.

To be frank, I don't understand why version 2 has now been posted (the
v1 review session didn't seem to ask for changes).

The v2 posting does not include any of the v1 review tags (your R-b, and
my A-b). Neither does v2 spell out the changes relative to v1, which
would justify the absence of the v1 feedback tags in the v2 posting.
It's hard for me to remain responsive when the due process is ignored.

(In case I missed the v2 changelog: I'm sorry.)

Thanks
Laszlo

[1] https://edk2.groups.io/g/devel/message/65608
[2] http://mid.mail-archive.com/9ae864d9-7eb7-2e60-f043-299a7f7b74a7@redhat.com
[3] https://listman.redhat.com/archives/edk2-devel-archive/2020-September/msg00736.html


      reply	other threads:[~2021-04-09 13:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  8:16 [PATCH v2] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib Jason Lou
2021-04-08  0:36 ` Ni, Ray
     [not found] ` <1673BAF6BEAFB94F.26818@groups.io>
2021-04-09  0:45   ` [edk2-devel] " Ni, Ray
2021-04-09 13:43     ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=710dd775-5380-942b-7981-c67c5bcdb584@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox