From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.9453.1617975827922552242 for ; Fri, 09 Apr 2021 06:43:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LcvSlvig; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617975827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fuDEESZGYaUaEP7fFOPWrm6ZKUL4lpOLdA+VhL6d52w=; b=LcvSlvigFMZi0jxb0ocotxAeFKLPjJD9JFxpzNSwPMiwK7qhphbr8tQwxI9Qq5/y8mP6om Mv+CDebRNOahlTEdIO22QPt2sBqUnwlC1ezNhKg1xf11bAeCj6HoxAInpaDMTAHM2lRPYP ke82Zn05wKNYNAmB7nfKNZqw/NWgT24= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-486-lVsaEcUOMouWehvTGKeK6w-1; Fri, 09 Apr 2021 09:43:43 -0400 X-MC-Unique: lVsaEcUOMouWehvTGKeK6w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51B97802B40; Fri, 9 Apr 2021 13:43:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-137.ams2.redhat.com [10.36.115.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC64960BE5; Fri, 9 Apr 2021 13:43:40 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib. To: "Ni, Ray" , "devel@edk2.groups.io" , "Lou, Yun" Cc: "Dong, Eric" , "Kumar, Rahul1" References: <20210407081625.14254-1-yun.lou@intel.com> <1673BAF6BEAFB94F.26818@groups.io> From: "Laszlo Ersek" Message-ID: <710dd775-5380-942b-7981-c67c5bcdb584@redhat.com> Date: Fri, 9 Apr 2021 15:43:39 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ray, On 04/09/21 02:45, Ni, Ray wrote: > Laszlo, > OVMF isn't using this timerlib so I will assume you doesn't care about > this change. correct; that's why I gave my ACK for v1 in last September [1] [2] [3] -- I didn't want to block progress on this patch. To be frank, I don't understand why version 2 has now been posted (the v1 review session didn't seem to ask for changes). The v2 posting does not include any of the v1 review tags (your R-b, and my A-b). Neither does v2 spell out the changes relative to v1, which would justify the absence of the v1 feedback tags in the v2 posting. It's hard for me to remain responsive when the due process is ignored. (In case I missed the v2 changelog: I'm sorry.) Thanks Laszlo [1] https://edk2.groups.io/g/devel/message/65608 [2] http://mid.mail-archive.com/9ae864d9-7eb7-2e60-f043-299a7f7b74a7@redhat.com [3] https://listman.redhat.com/archives/edk2-devel-archive/2020-September/msg00736.html