From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1106321E74919 for ; Mon, 4 Sep 2017 14:23:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE160267C5; Mon, 4 Sep 2017 21:25:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CE160267C5 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-2.rdu2.redhat.com [10.10.120.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCB9718167; Mon, 4 Sep 2017 21:25:49 +0000 (UTC) To: Ge Song , Jordan Justen , edk2-devel@lists.01.org Cc: Ard Biesheuvel References: <20170903021214.11516-1-ge.song@hxt-semitech.com> <20170903021214.11516-2-ge.song@hxt-semitech.com> <150453207055.10722.7097788282280420028@jljusten-skl> <7db5728c-a901-012e-0584-99c4b10d988e@gmail.com> From: Laszlo Ersek Message-ID: <711fe92e-7b15-e349-b853-65b07315053e@redhat.com> Date: Mon, 4 Sep 2017 23:25:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <7db5728c-a901-012e-0584-99c4b10d988e@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 04 Sep 2017 21:25:53 +0000 (UTC) Subject: Re: [PATCH v1 1/1] OvmfPkg/SecMain: Fix stack switching to permanent memory fail X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 21:23:05 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09/04/17 17:11, Ge Song wrote: > On 09/04/2017 09:34 PM, Jordan Justen wrote: > >> On 2017-09-03 16:55:36, Laszlo Ersek wrote: >>> On 09/03/17 04:12, Ge Song wrote: >>>> In earlier PEI stage, temporary memory(Cache As Ram) is employed as >>>> stack >>>> and heap. We move them to the new room and do some relocation fixup >>>> when >>>> permanent memory becomes available. TemporaryRamMigration() >>>> is responsible for switching the stack. >>> [...] >>> >>>> Cc: Jordan Justen >>>> Cc: Laszlo Ersek >>>> Cc: Ard Biesheuvel >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Ge Song >>>> --- >>>>   OvmfPkg/Sec/SecMain.c | 2 ++ >>>>   1 file changed, 2 insertions(+) >>> (No more separate emails, I promise.) >>> >>> Before you send v2, can you please amend the patch like this: >>> >>>    git commit --amend --author='Ge Song ' >>> >>> It's OK if you mail it out from another email address, but IMO the git >>> authorship should match the first Signed-off-by. >> I disagree with this. Unless the individual is well known to the EDK >> II community as the owner of both email addresses, I think the author >> needs to send it from their author email. >> >> I suppose they can send it from another email, and then reply from >> their other email saying they contributed it under the Tianocore >> Contribution Agreement, but that sounds like a stretch... I'm fine either way, as long as we can establish some kind of agreement between (two of?) the three email addresses (sender, git author, S-o-b). Thanks, Laszlo > OK, I'll try to send it from the same email address next time, the reason > that using two different mail addresses is because the author email is an > exchange account and it's hard to find the mail server preferences for > git-send-email... > >> >>> The commit message body currently does not start with "From: Ge Song >>> ", which means that the git authorship and the >>> first S-o-b disagree at the moment. >>> >>> ... If I'm wrong about this, I can be convinced, of course. >>> >>> Thanks >>> Laszlo >