From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 35D50D8018D for ; Tue, 31 Oct 2023 06:18:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VMnjoYHfTjD1gB/8EtfuSsxGXxkbuAjWSWn6lwmWPvY=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1698733110; v=1; b=WWm6KUSE9XH1rpnG/8/EvXo2Z9ldzC2zlYgLxTKGCpSS4jSvSI3Up5ksYVZji/+2uNQe25L8 q2eu83J/yxDtUt85mJx25CPSyMejd1U+bRPGo+l4pfVEyPsTfAWmUvhqtMQpEgeAlrRYcg7n5Sq khdzEA+5J94heAUl9BgBLWZI= X-Received: by 127.0.0.2 with SMTP id a8NrYY7687511xAvI7lUdV2U; Mon, 30 Oct 2023 23:18:30 -0700 Subject: Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V To: Sunil V L ,devel@edk2.groups.io From: "Dhaval Sharma" X-Originating-Location: IN (49.249.129.34) X-Originating-Platform: Linux Chrome 115 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 30 Oct 2023 23:18:30 -0700 References: In-Reply-To: Message-ID: <7135.1698733110277326842@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dhaval@rivosinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FAptJ3mclpqtpohNYmjU15Cxx7686176AA= Content-Type: multipart/alternative; boundary="FRs4VVpa6VKZgguxermk" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WWm6KUSE; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --FRs4VVpa6VKZgguxermk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable NIT: I am wondering whether PcdRiscVCpuFeatureDisable is better so that it is explicit. [Dhaval] Well setting it to 1 would mean feature is enabled. Do it would be= confusing to see PcdRiscVCpuFeatureDisable =3D=3D 1 means feature is enabl= ed. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110370): https://edk2.groups.io/g/devel/message/110370 Mute This Topic: https://groups.io/mt/102256468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --FRs4VVpa6VKZgguxermk Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable NIT: I am wondering whether= PcdRiscVCpuFeatureDisable is better so that
it = is explicit.
[Dhaval] Well setting it to 1 would mean feature i= s enabled. Do it would be confusing to see PcdRiscVCpuFeatureDisable =3D=3D 1 means feature is en= abled.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#110370) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--FRs4VVpa6VKZgguxermk--