From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 11 Jun 2019 08:42:06 -0700
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 2C9F0C0587F5;
	Tue, 11 Jun 2019 15:41:51 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-234.ams2.redhat.com [10.36.116.234])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 28F695DD8D;
	Tue, 11 Jun 2019 15:41:47 +0000 (UTC)
Subject: Re: [RFC] Fine-grained review ownership for MdeModulePkg
To: Leif Lindholm <leif.lindholm@linaro.org>, "Wu, Hao A" <hao.a.wu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>,
 Andrew Fish <afish@apple.com>, "Justen, Jordan L"
 <jordan.l.justen@intel.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 "Gao, Liming" <liming.gao@intel.com>, "Yao, Jiewen" <jiewen.yao@intel.com>,
 "Zeng, Star" <star.zeng@intel.com>
References: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8E49BD@SHSMSX104.ccr.corp.intel.com>
 <20190611095150.l7vmqyn3ln4gmvyq@bivouac.eciton.net>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <7139a616-fd47-796b-0e81-85cb2a5ff36f@redhat.com>
Date: Tue, 11 Jun 2019 17:41:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190611095150.l7vmqyn3ln4gmvyq@bivouac.eciton.net>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 11 Jun 2019 15:41:56 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 06/11/19 11:51, Leif Lindholm wrote:
> Hi Wu Hao,
>=20
> I am working on a proposal (and proof-of-concept) machine readable
> Maintainers.txt format, and a GetMaintainer.py script, based on the
> format used by QEMU.
>=20
> One of the key features of that format is the F: tag, which specifes a
> filesytem path (with wildcard support).

This is great news! QEMU's pathnames are very flexible.

>=20
> While this is just an RFC in progress (to be sent out later in week),
> if you could take that into account, and figure out which paths
> correspond to which areas of responsibility, that would make a test
> run of the script much easier.
>=20
> For my part, I would suggest adding (not just for MdeModulePkg)
> F: */ARM/*
> F: */AARCH64/*
> as maintained by myself and Ard.

* Under ArmVirtPkg, we distinguish "Xen modules":

R: Julien Grall <julien.grall@arm.com>
   (Xen modules)

I hope that Ard can come up with a set of patterns for these modules. :)

* Under OvmfPkg, we distinguish:

R: Anthony Perard <anthony.perard@citrix.com>
   (Xen modules)
R: Julien Grall <julien.grall@arm.com>
   (Xen modules)

and

R: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
   (TPM2 modules)
R: Stefan Berger <stefanb@linux.ibm.com>
   (TPM2 modules)

For "Xen modules", I'd suggest:

F: OvmfPkg/AcpiPlatformDxe/Xen.c
F: OvmfPkg/Include/Guid/Xen*.h
F: OvmfPkg/Include/IndustryStandard/Xen/
F: OvmfPkg/Include/Library/Xen*.h
F: OvmfPkg/Include/Protocol/Xen*.h
F: OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
F: OvmfPkg/Library/XenConsoleSerialPortLib/
F: OvmfPkg/Library/XenHypercallLib/
F: OvmfPkg/Library/XenIoMmioLib
F: OvmfPkg/PlatformPei/Xen.*
F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
F: OvmfPkg/XenBusDxe/
F: OvmfPkg/XenIoPciDxe/
F: OvmfPkg/XenPvBlkDxe/

For "TPM2 modules":

F: OvmfPkg/Include/IndustryStandard/QemuTpm.h
F: OvmfPkg/Library/Tcg2PhysicalPresenceLib*/
F: OvmfPkg/Tcg/

Thanks
Laszlo