From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Dandan Bi <dandan.bi@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms] [patch V4 11/37] Platform/ARM: Consume MdeLibs.dsc.inc for RegisterFilterLib
Date: Tue, 30 Mar 2021 19:59:58 -0700 [thread overview]
Message-ID: <7140.1617159598495954856@groups.io> (raw)
In-Reply-To: <20210328131125.26788-12-dandan.bi@intel.com>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
Hi Dandan,
On Sun, Mar 28, 2021 at 06:12 AM, Dandan Bi wrote:
>
> diff --git a/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> b/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> index 5c87a0ca9b..d9dfa7c4ae 100644
> --- a/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> +++ b/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> @@ -22,11 +22,14 @@ [Defines]
> BOARD_DXE_FV_COMPONENTS =
> Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.fdf.inc
> BUILD_NUMBER = 1
>
> # include common definitions from SgiPlatform.dsc
> !include Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> -!include Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc
> +!include Platform/ARM/SgiPkg/SgiMemoryMap.dsc.
The change above is not needed and breaks the build for RdN1EdgeX2 platform. Can you take a look, please?
>
> +
> +# include common/basic libraries from MdePkg.
> +!include MdePkg/MdeLibs.dsc.inc
With that changed.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 1097 bytes --]
next prev parent reply other threads:[~2021-03-31 2:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 13:10 [edk2-platforms] [patch V4 00/37] Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 01/37] Drivers/ASIX: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 02/37] Drivers/DisplayLink: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 03/37] Drivers/OptionRomPkg: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 04/37] Features/Debugging: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 05/37] Features/Network: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 06/37] Features/OutOfBandManagement: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 07/37] Features/PowerManagement: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 08/37] Features/SystemInformation: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 09/37] Features/UserInterface: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 10/37] Platform/AMD: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 11/37] Platform/ARM: " Dandan Bi
2021-03-31 2:59 ` Sami Mujawar [this message]
2021-03-28 13:11 ` [edk2-platforms] [patch V4 12/37] Platform/BeagleBoard: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 13/37] Platform/Comcast: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 14/37] Platform/Hisilicon: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 15/37] Platform/BoardModulePkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 16/37] Platform/MinPlatformPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 17/37] Platform/QuarkPlatformPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 18/37] Platform/Vlv2TbltDevicePkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 19/37] Platform/LeMaker: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 20/37] Platform/Marvell: " Dandan Bi
2021-03-30 13:58 ` [edk2-devel] " Marcin Wojtas
2021-03-28 13:11 ` [edk2-platforms] [patch V4 21/37] Platform/NXP: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 22/37] Platform/Qemu: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 23/37] Platform/RaspberryPi: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 24/37] Platform/RISC-V: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 25/37] Platform/SiFive: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 26/37] Platform/Socionext: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 27/37] Platform/SoftIron: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 28/37] Platform/SolidRun: " Dandan Bi
2021-03-30 13:57 ` Marcin Wojtas
2021-03-28 13:11 ` [edk2-platforms] [patch V4 29/37] Silicon/CoffeelakeSiliconPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 30/37] Silicon/IntelSiliconPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 31/37] Silicon/KabylakeSiliconPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 32/37] Silicon/QuarkSocPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 33/37] Silicon/TigerlakeSiliconPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 34/37] Silicon/Openmoko: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 35/37] Silicon/RISC_V: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 36/37] Silicon/Synopsys/DesignWare: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 37/37] Silicon/TexasInstruments: " Dandan Bi
2021-03-30 2:01 ` [edk2-devel] [edk2-platforms] [patch V4 00/37] " Michael D Kinney
2021-03-30 13:53 ` Dandan Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7140.1617159598495954856@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox