From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [edk2-platforms] [patch V4 11/37] Platform/ARM: Consume MdeLibs.dsc.inc for RegisterFilterLib
To: Dandan Bi <dandan.bi@intel.com>,devel@edk2.groups.io
From: "Sami Mujawar" <sami.mujawar@arm.com>
X-Originating-Location: GB (217.140.99.251)
X-Originating-Platform: Windows Firefox 87
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Tue, 30 Mar 2021 19:59:58 -0700
References: <20210328131125.26788-12-dandan.bi@intel.com>
In-Reply-To: <20210328131125.26788-12-dandan.bi@intel.com>
Message-ID: <7140.1617159598495954856@groups.io>
Content-Type: multipart/alternative; boundary="9owkPBjrKtvz2cVeTDnk"

--9owkPBjrKtvz2cVeTDnk
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Dandan,

On Sun, Mar 28, 2021 at 06:12 AM, Dandan Bi wrote:

>=20
> diff --git a/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> b/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> index 5c87a0ca9b..d9dfa7c4ae 100644
> --- a/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> +++ b/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> @@ -22,11 +22,14 @@ [Defines]
> BOARD_DXE_FV_COMPONENTS =3D
> Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.fdf.inc
> BUILD_NUMBER =3D 1
>=20
> # include common definitions from SgiPlatform.dsc
> !include Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> -!include Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc
> +!include Platform/ARM/SgiPkg/SgiMemoryMap.dsc.

The change above is not needed and breaks the build for RdN1EdgeX2 platfor=
m. Can you take a look, please?

>=20
> +
> +# include common/basic libraries from MdePkg.
> +!include MdePkg/MdeLibs.dsc.inc

With that changed.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

--9owkPBjrKtvz2cVeTDnk
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Dandan,<br /><br />On Sun, Mar 28, 2021 at 06:12 AM, Dandan Bi wrote:<br=
 />
<blockquote>diff --git a/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc b/P=
latform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc<br />index 5c87a0ca9b..d9dfa7c=
4ae 100644<br />--- a/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc<br />++=
+ b/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc<br />@@ -22,11 +22,14 @@ =
[Defines]<br />BOARD_DXE_FV_COMPONENTS =3D Platform/ARM/SgiPkg/RdN1EdgeX2/R=
dN1EdgeX2.fdf.inc<br />BUILD_NUMBER =3D 1<br /><br /># include common defin=
itions from SgiPlatform.dsc<br />!include Platform/ARM/SgiPkg/SgiPlatform.d=
sc.inc<br />-!include Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc<br />+!inclu=
de Platform/ARM/SgiPkg/SgiMemoryMap.dsc.</blockquote>
The change above is not needed and breaks the build for RdN1EdgeX2 platfor=
m. Can you take a look, please?<br /><br />
<blockquote>+<br />+# include common/basic libraries from MdePkg.<br />+!i=
nclude MdePkg/MdeLibs.dsc.inc</blockquote>
With that changed.<br /><br />Reviewed-by: Sami Mujawar &lt;sami.mujawar@a=
rm.com&gt;<br /><br />Regards,<br /><br />Sami Mujawar

--9owkPBjrKtvz2cVeTDnk--