From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.2491.1583782334095262342 for ; Mon, 09 Mar 2020 12:32:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OHw+GY0/; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583782333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DLGcteyVXWKfRtpTQCW+gQ60oXtvDj3Fc8py1Il9nMs=; b=OHw+GY0/dXli8DFpLAIis9Yk7HH+w2xdVCBzofZwQapDtH55HwgXlHeYgCmY7DfAhqKKZs zlAdKVVetCFBMiBYAxCESe3OtyVIxJvvsupJlzFnHw3WXRX1B7jm+7gNqm3BHUL0F9buAD TCwIaUPEBq5/Sl8Uak7t6+jvZVAhcw4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-8wvyF8w_PQW9hzX2O1gAwA-1; Mon, 09 Mar 2020 15:32:10 -0400 X-MC-Unique: 8wvyF8w_PQW9hzX2O1gAwA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37A7E1005509; Mon, 9 Mar 2020 19:32:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-76.ams2.redhat.com [10.36.116.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF38E8B75C; Mon, 9 Mar 2020 19:32:07 +0000 (UTC) Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master From: "Laszlo Ersek" To: "Kinney, Michael D" , "devel@edk2.groups.io" , "sean.brogan@microsoft.com" , Bret Barkelew , "Gao, Liming" Cc: "Leif Lindholm (Nuvia address)" , Andrew Fish References: <01473986-a0f7-6143-6f81-63611f1f6b00@redhat.com> Message-ID: <7144d0bb-7c24-17e2-d6b2-73b5976c644e@redhat.com> Date: Mon, 9 Mar 2020 20:32:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <01473986-a0f7-6143-6f81-63611f1f6b00@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 03/09/20 20:29, Laszlo Ersek wrote: > Hi Mike, > > On 03/08/20 20:53, Kinney, Michael D wrote: >> I added the @Mergifyio refresh to these PRs. >> >> This one was merged: >> https://github.com/tianocore/edk2/pull/427 >> >> This one is failing PatchCheck with a missing Signed-off-by >> https://github.com/tianocore/edk2/pull/430 >> >> This one needs to be rebased and resubmitted >> https://github.com/tianocore/edk2/pull/428 > > Thanks for kicking mergify. > > I think maintainers should have permission to kick mergify (if they > don't have that permission already). Otherwise, the automated > merge-on-CI-pass is not actually automated, and we create a bottleneck > in an otherwise distributed / asynchronous workflow. If only you can > kick mergify, then any *valid* (CI-clean) pull request will potentially > have to wait on you. > > Mergify kicking rights do not allow maintainers to bypass CI checks, if > I understand correctly. (Unlike direct merge / repository write access.) > > BTW I didn't even know about this mergify "command". Is there a guide > somewhere? > > I honestly feel this should have been handled / introduced more > transparently. I rarely feel as powerless as with PR#428. CI passed, the > PR was stuck, github didn't respond to my ticket, mergify.io didn't > respond to my ticket, and the PR was actually urgent (fixing a build > breakage). I was sitting there uncomfortably as one of the stewards, > unable to fix the situation. Earlier all this would take was a git-push > command. Yup, just seen this too: "@lersek is not allowed to run commands" :/