From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web11.405.1571078233228029262 for ; Mon, 14 Oct 2019 11:37:13 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1FCD3CA06; Mon, 14 Oct 2019 18:37:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-254.ams2.redhat.com [10.36.117.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40371196AE; Mon, 14 Oct 2019 18:37:07 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 0/2] PlatformBootManagerLib: Don't update progress if Pcd is 0 To: devel@edk2.groups.io, pete@akeo.ie Cc: afish@apple.com, liming.gao@intel.com References: <20191014150311.16740-1-pete@akeo.ie> From: "Laszlo Ersek" Message-ID: <716f1268-882a-ad5f-31dc-679e549f68fc@redhat.com> Date: Mon, 14 Oct 2019 20:36:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191014150311.16740-1-pete@akeo.ie> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 14 Oct 2019 18:37:12 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/14/19 17:03, Pete Batard wrote: > Changes from previous version: > - Additional empty comment lines above and below, to keep with existing comment > style > - Similar logic is applied to ArmVirtPkg/PlatformBootManagerLib, since the same > issue may manifest itself here. > > Pete Batard (2): > OvmfPkg/PlatformBootManagerLib: Don't update progress if Pcd is 0 > ArmVirtPkg/PlatformBootManagerLib: Don't update progress if Pcd is 0 > > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 14 +++++++++++--- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 15 ++++++++++++--- > 2 files changed, 23 insertions(+), 6 deletions(-) > Thanks. I'll add the BZ reference to patch#2 too, and then push the series tomorrow (with feedback tags from Phil and others picked up, of course). Every set should spend 24h on the list, before being pushed. Thanks! Laszlo