public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sean" <sean.brogan@microsoft.com>
To: Gao, Zhichao <zhichao.gao@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg/GraphicsConsoleDxe: Do not clean the screen
Date: Thu, 25 Apr 2019 18:12:28 -0700	[thread overview]
Message-ID: <7170.1556241148246604928@groups.io> (raw)
In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7C4343@SHSMSX101.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Is there a branch where this code change can be reviewed?  

The intent of bug 1412 was not to break spec alignment on the uefi defined protocol and SetMode() function.  We had a proposed change that can be seen here. https://github.com/Microsoft/mu_basecore/pull/13/files 
The idea was for new devices published, only clear the screen if the mode needs to change.  Our reading of the UEFI spec didn't define how new devices needed to be added and didn't require the screen be cleared.

[-- Attachment #2: Type: text/html, Size: 670 bytes --]

  reply	other threads:[~2019-04-26  1:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23  7:04 [PATCH V2 0/2] MdeModulePkg: Make the screen seamless Gao, Zhichao
2019-04-23  7:04 ` [PATCH V2 1/2] MdeModulePkg/ConSplitterDxe: Optimize the ConSplitterTextOutSetMode Gao, Zhichao
2019-04-23  7:04 ` [PATCH V2 2/2] MdeModulePkg/GraphicsConsoleDxe: Do not clean the screen Gao, Zhichao
2019-04-23 13:50   ` Laszlo Ersek
2019-04-24  2:37     ` [edk2-devel] " Gao, Zhichao
2019-04-24 10:24       ` Laszlo Ersek
2019-04-24 10:48         ` Laszlo Ersek
2019-04-25 15:21           ` Gao, Zhichao
2019-04-26  1:12             ` Sean [this message]
2019-04-26  2:38               ` Gao, Zhichao
2019-04-26 19:25                 ` Sean
2019-04-28  0:27                   ` Gao, Zhichao
2019-04-30  1:07                     ` Sean
2019-04-30  8:58                       ` Gao, Zhichao
2019-04-26 18:07             ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7170.1556241148246604928@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox