From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mx.groups.io with SMTP id smtpd.web11.6998.1618364491371399136 for ; Tue, 13 Apr 2021 18:41:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=CK+oIZ/g; spf=pass (domain: nuviainc.com, ip: 209.85.216.53, mailfrom: rebecca@nuviainc.com) Received: by mail-pj1-f53.google.com with SMTP id x21-20020a17090a5315b029012c4a622e4aso9957767pjh.2 for ; Tue, 13 Apr 2021 18:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ODtOq3fJiyQVfXYucb61R35uhvkTm6lk0KP+bBXzaXQ=; b=CK+oIZ/g1VaQcpQvr7d2jsE1XpsOl5hipfy4Zq05LY6w8NeTlnh2zupymoeBfWEbfj hNjTvxODZyjA+uQ/9czNSLbNCpN8pCqn+xnEjz12yaHRro8weSy6TQfvOcN8obKsLJIS lVH/PeQ99S3kBH0Ys/f+swSkqoG7QF+LhmLo+dUsROu6joadFym4luPauBEK5c+ZF0Re P2i4b7+HhXMfhK394Bt2nz/qG5i0mL0JVXswvlv8xjkcGv22IBQ2jH2tumOOyGNneKI8 ntGfbzKiaZMJeGIiT/KeiCxDeJdi8p+//UMawTxuEdC4wWJTyByiiphQNZAkLBiK24Ar Ogvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ODtOq3fJiyQVfXYucb61R35uhvkTm6lk0KP+bBXzaXQ=; b=LUDAeR9FGBTwUhYdrYFTFyAkuDIfYEg3ixrzatenNQmgqFXHcfhKls8COeEqNIEUFD esQyiiVJBMHu3r+vcJJHUyIaMk2Ys4sdmVzviDcFMnb3JYiQBuUQ2yjnDF1fSCkOovYX MYm8hWInM2HehkRs5ZeriHP7j4zLz9pvx7gL39HJ1uqBSFWI01At6r0vt5DJ2JpwiUrd ffkzCaZie6er03l/nuwnsYbohB+pAy3w+11lb27/PYCYytSTf88hIRZZOaPGfbsSnAjo LlxRuDM+VO2mggI3Be0J9AW59nlvO6AJm7exQ97FddIHwvmH7CsliiVDMltaShlvLznp QVTQ== X-Gm-Message-State: AOAM530cJVM+oD/P2JpiaXYdCOQR+7hIffLw5juw4xZcFgyATpyc0XbS AjeiN/Gfb2OHW7NMeW9Nv862pQ== X-Google-Smtp-Source: ABdhPJwkO2kPpmUAloJVJjqqK9ekL0DhOkPtEedar5+mHq9Co63bVOe6C8J688DzT6wBDz6Isafnyg== X-Received: by 2002:a17:902:d64f:b029:e7:1f02:5741 with SMTP id y15-20020a170902d64fb02900e71f025741mr34591737plh.48.1618364490829; Tue, 13 Apr 2021 18:41:30 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id z18sm13249364pfa.39.2021.04.13.18.41.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 18:41:30 -0700 (PDT) Subject: Re: [PATCH 1/5] ArmPkg: Allow platforms to override PCI supported state in SmbiosMiscDxe To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel References: <20210331021619.19761-1-rebecca@nuviainc.com> <20210331021619.19761-2-rebecca@nuviainc.com> <20210413165117.GC1664@vanye> From: "Rebecca Cran" Message-ID: <7183e8b8-b97b-e534-0ad5-ba26d8d689ee@nuviainc.com> Date: Tue, 13 Apr 2021 19:41:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210413165117.GC1664@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/13/21 10:51 AM, Leif Lindholm wrote: > On Tue, Mar 30, 2021 at 20:16:15 -0600, Rebecca Cran wrote: >> Not all platforms support PCI, so introduce a PCD to allow platforms to >> specify whether they support it. > > Are we planning to add one? Not that I know of. > If not, I'd rather skip this until we do. > These days, I would expect any platform providing SMBIOS tables to > have PCI. I added it based on feedback on the original review (I think Samer requested it), but it sounds like dropping it would be fine. -- Rebecca Cran > > No further comments on this set. > > / > Leif > >> Signed-off-by: Rebecca Cran >> --- >> ArmPkg/ArmPkg.dec | 1 + >> ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 + >> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 4 ++++ >> 3 files changed, 6 insertions(+) >> >> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec >> index a8a22c649ff8..51ac2191c85a 100644 >> --- a/ArmPkg/ArmPkg.dec >> +++ b/ArmPkg/ArmPkg.dec >> @@ -125,6 +125,7 @@ [PcdsFixedAtBuild.common] >> # >> # SMBIOS PCDs >> # >> + gArmTokenSpaceGuid.PcdPlatformSupportsPCI|TRUE|BOOLEAN|0x30000052 >> gArmTokenSpaceGuid.PcdSystemProductName|L""|VOID*|0x30000053 >> gArmTokenSpaceGuid.PcdSystemVersion|L""|VOID*|0x30000054 >> gArmTokenSpaceGuid.PcdBaseBoardManufacturer|L""|VOID*|0x30000055 >> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >> index 60d8fe31c219..ebc4c99ac436 100644 >> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >> @@ -71,6 +71,7 @@ [Pcd] >> gArmTokenSpaceGuid.PcdFdSize >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString >> + gArmTokenSpaceGuid.PcdPlatformSupportsPCI >> gArmTokenSpaceGuid.PcdSystemBiosRelease >> gArmTokenSpaceGuid.PcdEmbeddedControllerFirmwareRelease >> gArmTokenSpaceGuid.PcdSystemProductName >> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c >> index 5aea32521bd3..a06f814aeb7c 100644 >> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c >> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> @@ -264,6 +265,9 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) >> UnicodeStrToAsciiStrS (Version, StrStart, VerStrLen + 1); >> StrStart += VerStrLen + 1; >> UnicodeStrToAsciiStrS (ReleaseDate, StrStart, DateStrLen + 1); >> + >> + SmbiosRecord->BiosCharacteristics.PciIsSupported = FixedPcdGetBool (PcdPlatformSupportsPCI); >> + >> // >> // Now we have got the full smbios record, call smbios protocol to add this record. >> // >> -- >> 2.26.2 >>