From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web10.5773.1579088067962661164
 for <devel@edk2.groups.io>;
 Wed, 15 Jan 2020 03:34:28 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XhTbKGv+;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1579088067;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/fZFcajATdk2Sp6T9IhUUSsnnhoLytXr9MiGRjrt9e8=;
	b=XhTbKGv+Lrr+brkI4E2IogaHPkR49uCiyMphDt1r3pScQqF/p6ffDAhNEdvDAcDf3Lm2yg
	5qCGFB1C4USm4Xkb9y6FJ6dGCKG3xT1SEfzqDRTKGkEa/CSyOO1Zv4xnhRqqVBi17aOv5H
	yChzWlpcXB/Msd8L8R7i4C9Z9dqFeYo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-25-B3rKls7HM3uEG8le3WEzhg-1; Wed, 15 Jan 2020 06:34:24 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E2F47802C86;
	Wed, 15 Jan 2020 11:34:22 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-98.ams2.redhat.com [10.36.116.98])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 82D2B5C1D6;
	Wed, 15 Jan 2020 11:34:19 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: fix 2M->4K page splitting regression for PDEs
To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>,
 devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>
References: <20200109232512.11022-1-lersek@redhat.com>
 <7efbb866-7738-dd92-9cee-6bca35207c40@redhat.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <71907eec-f59b-281d-1842-f05346fda472@redhat.com>
Date: Wed, 15 Jan 2020 12:34:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <7efbb866-7738-dd92-9cee-6bca35207c40@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-MC-Unique: B3rKls7HM3uEG8le3WEzhg-1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable

On 01/15/20 12:08, Philippe Mathieu-Daud=E9 wrote:
> On 1/10/20 12:25 AM, Laszlo Ersek wrote:
>> In commit 4eee0cc7cc0d ("UefiCpuPkg/PiSmmCpu: Enable 5 level paging when
>> CPU supports", 2019-07-12), the Page Directory Entry setting was
>> regressed
>> (corrupted) when splitting a 2MB page to 512 4KB pages, in the
>> InitPaging() function.

>> Remove the useless assignment to (*Pd) from before the loop. Revert the
>> loop incrementing and the PTE assignment to the known good version.

> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Thank you!
Laszlo